Admin interface#703
Open
MarkWolters wants to merge 6 commits into
Open
Conversation
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JMX Runtime Configuration for Graph Index Builder
Introduces
GraphIndexBuilderConfig, a JMX-managed singleton that exposesGraphIndexBuilderconstruction parameters as runtime-tunable attributes. Before this change, options such asaddHierarchy,refineFinalGraph,parallelBuild, and build-time compression type could only be set at the call site and required a code change or restart to modify.What's new
managementpackage —GraphIndexBuilderConfigMBeandeclares 8 managed attributes across four groups (graph topology, write path, build compression type, PQ parameters);GraphIndexBuilderConfigis the singleton implementation registered underio.github.jbellis.jvector:type=GraphIndexBuilderConfig.CompressionTypeenum (NONE,PQ,BQ) drives build-time scoring compression selection.GraphIndexBuilder— New constructor(RandomAccessVectorValues, VectorSimilarityFunction, …)readsaddHierarchy,refineFinalGraph, and compression type fromGraphIndexBuilderConfigat construction time. Existing constructors that accept those booleans explicitly are deprecated but unchanged in behavior. The newgetBuildScoreProviderhelper wires PQ and BQ build-time compression end-to-end using the JMX-configured parameters.RandomAccessOnDiskGraphIndexWriter.Builder— Unified builder replaces the separateOnDiskGraphIndexWriter.Builder. ReadsGraphIndexBuilderConfig.isParallelBuild()at build time to selectOnDiskParallelGraphIndexWriterorOnDiskGraphIndexWriter. Both produce an identical on-disk format, so the flag can be toggled without re-indexing.No breaking changes — All existing API call sites continue to compile and behave identically; deprecated constructors are retained and honor caller-supplied values.
Attributes managed via JMX
AddHierarchyRefineFinalGraphParallelBuildBuildCompressionType"NONE"PqMFactorPqKPqCenterDataPqAnisotropicThresholdAll attributes are
@Experimental. MBean registration is best-effort — failure logs a warning but does not affect normal operation.