Skip to content

Fix #227: handle multiple statements with hooks - #228

Merged
sunng87 merged 2 commits into
datafusion-contrib:masterfrom
watford-ep:bug/227-multiple-hooks-unhandled
Oct 31, 2025
Merged

sunng87 merged 2 commits into
datafusion-contrib:masterfrom
watford-ep:bug/227-multiple-hooks-unhandled

Conversation

@watford-ep

Copy link
Copy Markdown
Contributor

This PR addresses an issue when multiple statements appear in a simple query and at least one of which is handled by a hook.

Basically I had hooks for RESET, CLOSE, DISCARD, and UNLISTEN (contribution requires an upstream change to datafusion-sqlparser-rs which has been proposed), and npgsql issued them all in the same query. Only one of these would be handled causing npgsql to timeout.

Fixes #227

@sunng87

sunng87 commented Oct 30, 2025

Copy link
Copy Markdown
Member

@watford-ep Thank you for the fix! Could you please fix the format and I will merge it.

@watford-ep

Copy link
Copy Markdown
Contributor Author

Done!

@sunng87

sunng87 commented Oct 31, 2025

Copy link
Copy Markdown
Member

Thank you @watford-ep ! I will create a patch release soon.

@sunng87
sunng87 merged commit 4008fa5 into datafusion-contrib:master Oct 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simple query handler does not support multiple hooks

2 participants