Skip to content

Allow tax_status to be updateable by consortium admin for consortium and consortium organizations - #979

Merged
svogt0511 merged 6 commits into
mainfrom
pb938-tax-status
Jul 9, 2026
Merged

svogt0511 merged 6 commits into
mainfrom
pb938-tax-status

Conversation

@svogt0511

@svogt0511 svogt0511 commented Jun 24, 2026 •

Copy link
Copy Markdown
Contributor

Purpose

closes: #938

Ensure that the "tax status" form entry shows up on the appropriate forms, and is updateable by a consortium admin.

preview: https://bracco-mbhq9o91h-datacite.vercel.app/

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@svogt0511 svogt0511 changed the title Add consortium admin to abilities calculation for 'create' Allow tax_status to be updateable for a consortium admin Jun 24, 2026
@svogt0511
svogt0511 temporarily deployed to vercel-bracco-preview June 25, 2026 16:08 — with GitHub Actions Inactive
@svogt0511
svogt0511 temporarily deployed to vercel-bracco-preview June 25, 2026 18:22 — with GitHub Actions Inactive
@svogt0511 svogt0511 self-assigned this Jun 25, 2026
@svogt0511
svogt0511 requested review from a team, KellyStathis and codycooperross June 25, 2026 18:45
@svogt0511 svogt0511 changed the title Allow tax_status to be updateable for a consortium admin Allow tax_status to be updateable by consortium admin for consortium and consortium organizations Jun 25, 2026

@KellyStathis KellyStathis left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve taken a look at this and the Tax Status field now appears for both Consortium Leads and Consortium Organizations when updating a Consortium Organization account.

However, the field "Salesforce ID" now appears for Consortium Leads. This should only be visible to Admin. Would it be possible to suppress it for Consortium Leads?

Another small change that would be good to have is the field order. Could we have "Tax Status" appear directly below "Country" for both account types?

…tion. Move tax status field to below country field on create/update organization
@svogt0511
svogt0511 temporarily deployed to vercel-bracco-preview July 8, 2026 20:17 — with GitHub Actions Inactive
@svogt0511
svogt0511 requested a review from KellyStathis July 8, 2026 20:26
@KellyStathis

Copy link
Copy Markdown
Collaborator

@svogt0511 On the latest preview here: https://bracco-65r5otp80-datacite.vercel.app/

I logged in as a Consortium and went to update a Consortium Organization. There was a new field that appeared, "Consortium", which provides a way to select the Consortium that the Consortium Organization is part of:

Screenshot 2026-07-08 at 13 41 46

This should not be visible from the Consortium view, since a Consortium shouldn't be able to move their Consortium Organizations to a different Consortium.

@svogt0511
svogt0511 temporarily deployed to vercel-bracco-preview July 8, 2026 21:11 — with GitHub Actions Inactive
@svogt0511

Copy link
Copy Markdown
Contributor Author

@svogt0511 On the latest preview here: https://bracco-65r5otp80-datacite.vercel.app/

I logged in as a Consortium and went to update a Consortium Organization. There was a new field that appeared, "Consortium", which provides a way to select the Consortium that the Consortium Organization is part of:

Screenshot 2026-07-08 at 13 41 46 This should not be visible from the Consortium view, since a Consortium shouldn't be able to move their Consortium Organizations to a different Consortium.

In staging both fields member type and consortium are gone. I will put it back to that.

@svogt0511
svogt0511 temporarily deployed to vercel-bracco-preview July 9, 2026 15:30 — with GitHub Actions Inactive
@svogt0511

Copy link
Copy Markdown
Contributor Author

@KellyStathis - Changes have been made. See the preview: https://bracco-mbhq9o91h-datacite.vercel.app/ Let me know. Thanks again!

@svogt0511
svogt0511 merged commit be9cbb3 into main Jul 9, 2026
8 checks passed
@svogt0511
svogt0511 deleted the pb938-tax-status branch July 9, 2026 20:09

This branch was previously deployed

1 inactive deployment
vercel-bracco-preview — 6532ced9 Deployed Jul 9, 2026 by svogt0511 via Deploy to Vercel Preview #897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Tax Status field cannot be updated in the Consortium Organization accounts when logged in to Fabrica with a Consortium Lead account

3 participants