fix(deps): bump vulnerable transitive deps to patched versions (#405)#434
Open
MarioCadenas wants to merge 1 commit into
Open
fix(deps): bump vulnerable transitive deps to patched versions (#405)#434MarioCadenas wants to merge 1 commit into
MarioCadenas wants to merge 1 commit into
Conversation
A fresh app on @databricks/appkit / @databricks/appkit-ui tripped a clean `npm audit` because several deps were pinned under published advisories, and the OpenTelemetry/ws chain reported `fixAvailable: false` downstream. Direct bumps (propagate to downstream consumers): - OpenTelemetry cohort 0.208.0 -> 0.218.0 / stable 2.x -> 2.7.1, auto-instrumentations-node 0.67.2 -> 0.76.0, instrumentation-express 0.57.0 -> 0.66.0 (clears HIGH GHSA-q7rr-3cgh-j5r3 Prometheus exporter crash) - ws 8.18.3 -> 8.21.0 (GHSA-58qx-3vcg-4xpx) - dompurify 3.3.3 -> 3.4.8 (GHSA-39q2-94rc-95cp, GHSA-v9jr-rg53-9pgp) Transitive pins via scoped pnpm.overrides (cleans our tree + shipped SBOM): - protobufjs <7.6.2 -> 7.6.2 (in-range for @grpc/proto-loader ^7.5.3) - qs <6.15.2 -> 6.15.2 (GHSA-q8mj-m7cp-5q26; express 4.x caps qs at ~6.14.0) Verified: pnpm build, typecheck (all packages), and full test suite (2801 tests) pass. OTel cohort aligned per sdk-node@0.218.0 deps. Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
MarioCadenas
force-pushed
the
fix/405-bump-vulnerable-deps
branch
from
8ae2325 to
c825658
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #405. A fresh app on the latest
@databricks/appkit/@databricks/appkit-uitrips a cleannpm auditbecause several deps were pinned under published advisories — and the OpenTelemetry/ws chain reportedfixAvailable: falsedownstream because the pins live inside AppKit's tree.This splits the fix into direct bumps that propagate to downstream consumers and scoped
pnpm.overridesfor transitive pins that can only be cleaned in our own tree + SBOM.Direct bumps (reach downstream consumers)
api-logs,instrumentation,instrumentation-http,*-otlp-protoexporters,sdk-node,sdk-logs)0.208.0→0.218.0GHSA-q7rr-3cgh-j5r3(HIGH, Prometheus exporter crash)resources,sdk-metrics,sdk-trace-base,context-async-hooks)2.2.0–2.6.x→2.7.1auto-instrumentations-node/instrumentation-express0.67.2/0.57.0→0.76.0/0.66.0ws8.18.3→8.21.0GHSA-58qx-3vcg-4xpxdompurify(appkit-ui)3.3.3→3.4.8GHSA-39q2-94rc-95cp,GHSA-v9jr-rg53-9pgpThe OTel versions are exactly the set
sdk-node@0.218.0declares, so there are no peer-dep conflicts.Transitive overrides (scoped
pnpm.overrides)protobufjs(via@grpc/proto-loader) andqs(viaexpress) are transitive, so a direct bump can't move them:protobufjs@<7.6.2→7.6.2(in-range for proto-loader's^7.5.3)qs@<6.15.2→6.15.2Honest scope note: overrides in a published package's
package.jsondo not apply to a downstream install, so these clean our own tree and the shippedsbom.cdx.jsononly.qsstays capped at~6.14.0for consumers until anexpress5 migration (breaking, tracked separately).Verification
pnpm build✅pnpm -r typecheck✅protobufjs@7.6.2,qs@6.15.2,ws@8.21.0,dompurify@3.4.8)