Skip to content

OpenCL fast tiling fix plus maintenance - #22097

Merged
TurboGit merged 1 commit into
darktable-org:masterfrom
jenshannoschwalm:various_opencl_fixes
Aug 31, 2026
Merged

OpenCL fast tiling fix plus maintenance#22097
TurboGit merged 1 commit into
darktable-org:masterfrom
jenshannoschwalm:various_opencl_fixes

Conversation

@jenshannoschwalm

Copy link
Copy Markdown
Collaborator
  1. The OpenCL fast tiling code had two bugs now fixed
    a) the per line requirements for tiling were calculated too small leading to larger tile sizes than allowed
    b) the aligning of tile sizes was wrong leading to bad overlaps (this could be seen in 0153 integration test having much larger CPU/GPU diffs)
  2. Some maintenance and subtle perf improvements
    a) some constify
    b) more use of readpixel() variants - in some cases using the faster Aread.. variant
    c) more use of dtcl_xxx macros

1. The OpenCL fast tiling code had two bugs now fixed
   a) the per line requirements for tiling were calculated too small leading to
      larger tile sizes than allowed
   b) the aligning of tile sizes was wrong leading to bad overlaps (this could be seen
      in 0153 integration test having much larger CPU/GPU diffs)
2. Some maintenance and subtle perf improvements
   a) some constify
   b) more use of readpixel() variants - in some cases using the faster Aread.. variant
   c) more use of dtcl_xxx macros
@jenshannoschwalm jenshannoschwalm added this to the 5.8 milestone Aug 31, 2026
@jenshannoschwalm jenshannoschwalm added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: performance doing everything the same but faster scope: codebase making darktable source code easier to manage OpenCL Related to darktable OpenCL code labels Aug 31, 2026
@jenshannoschwalm

Copy link
Copy Markdown
Collaborator Author

@TurboGit integrations tests all good :-)

BTW - we have some subtle new CPU diffs after @kofa did the math fixing for color/tone equalizers.

@TurboGit

Copy link
Copy Markdown
Member

BTW - we have some subtle new CPU diffs after @kofa did the math fixing for color/tone equalizers.

Number of pixel diff, right?

@jenshannoschwalm

Copy link
Copy Markdown
Collaborator Author

Number of pixel diff, right?

      Expected CPU vs. current CPU report :
      ----------------------------------
      Max dE                   : 2.20445
      Avg dE                   : 0.00012
      Std dE                   : 0.00886
      ----------------------------------
      Pixels below avg + 0 std : 99.98 %
      Pixels below avg + 1 std : 99.98 %
      Pixels below avg + 3 std : 99.98 %
      Pixels below avg + 6 std : 99.98 %
      Pixels below avg + 9 std : 99.98 %
      ----------------------------------
      Pixels above tolerance   : 0.00 %

@TurboGit

Copy link
Copy Markdown
Member

Right, we had:

Test 0159-coloreq-guided-filter
      Image mire1.cr2
      Expected CPU vs. current CPU report :
      ----------------------------------
      Max dE                   : 1.13387
      Avg dE                   : 0.00333
      Std dE                   : 0.03597
      ----------------------------------
      Pixels below avg + 0 std : 98.99 %
      Pixels below avg + 1 std : 99.00 %
      Pixels below avg + 3 std : 99.06 %
      Pixels below avg + 6 std : 99.14 %
      Pixels below avg + 9 std : 99.50 %
      ----------------------------------
      Pixels above tolerance   : 0.00 %

So a bit worst now.

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit
TurboGit merged commit d3e1441 into darktable-org:master Aug 31, 2026
6 checks passed
@jenshannoschwalm
jenshannoschwalm deleted the various_opencl_fixes branch August 31, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug OpenCL Related to darktable OpenCL code priority: high core features are broken and not usable at all, software crashes scope: codebase making darktable source code easier to manage scope: performance doing everything the same but faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants