OpenCL fast tiling fix plus maintenance - #22097
Merged
TurboGit merged 1 commit intoAug 31, 2026
Merged
Conversation
1. The OpenCL fast tiling code had two bugs now fixed
a) the per line requirements for tiling were calculated too small leading to
larger tile sizes than allowed
b) the aligning of tile sizes was wrong leading to bad overlaps (this could be seen
in 0153 integration test having much larger CPU/GPU diffs)
2. Some maintenance and subtle perf improvements
a) some constify
b) more use of readpixel() variants - in some cases using the faster Aread.. variant
c) more use of dtcl_xxx macros
Collaborator
Author
Member
Number of pixel diff, right? |
Collaborator
Author
|
Member
|
Right, we had: So a bit worst now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a) the per line requirements for tiling were calculated too small leading to larger tile sizes than allowed
b) the aligning of tile sizes was wrong leading to bad overlaps (this could be seen in 0153 integration test having much larger CPU/GPU diffs)
a) some constify
b) more use of readpixel() variants - in some cases using the faster Aread.. variant
c) more use of dtcl_xxx macros