Fix guides menu toggle

[zisoft]

Some iop modules have the "show guides" checkbox (crop, rotate & perspective, flip, lens, clipping...).

The state of this checkbox can also be toggled via the module's presets menu but in that case the checkbox in the module itself is not toggled.

Activating this menu item also throws a GTK critical error:

Gtk-CRITICAL: gtk_toggle_button_set_active: assertion 'GTK_IS_TOGGLE_BUTTON (toggle_button)' failed

[piratenpanda]

Must have missed that. Thanks!

[da-phil]

Just out of curiosity, why do we need to have so many iop modules with their own "show guides" checkbox, when we have a central one in the bottom bar in the bottom right?

[TurboGit]

Just out of curiosity, why do we need to have so many iop modules with their own "show guides" checkbox, when we have a central one in the bottom bar in the bottom right?

That's a good question. This has been discussed before I was manager of the project. I was not against but always found that it is a bit redundant. The idea was to have the control closer to the mouse when dealing with modules where guides are often used. It is also a way to record if for such or such module a guided should be displayed, but for this we can keep the entry in the module's preference menu.

So maybe we can re-discuss the removal of the check box in module's main UI. If you feel this important please open a new issue to track this discussion. This should not be part of this PR.

[TurboGit]

Thanks!