Skip to content

feat(kasm): separate db-init-job annotations (upstream PR #29) - #57

Closed
darkhonor wants to merge 1 commit into
mainfrom
upstream/pr-29-db-init-annotations
Closed

darkhonor wants to merge 1 commit into
mainfrom
upstream/pr-29-db-init-annotations

Conversation

@darkhonor

Copy link
Copy Markdown
Owner

Summary

  • Ports kasmtech/kasm-helm#29 by @matonb
  • Creates dedicated components.init_db.annotations and components.init_db.labels config
  • db-init-job template uses init_db instead of api variables
  • Default includes helm.sh/hook: pre-install; GitOps users can override to prevent deadlocks

Why

Enables adding pre-upgrade and hook-delete-policy via values overrides instead of template forks. Complements our issue kasmtech/kasm-helm#35 findings 3 and 4.

Test plan

  • helm lint charts/kasm
  • helm template with default values — verify db-init-job has helm.sh/hook: pre-install
  • helm template with custom components.init_db.annotations — verify override works

🤖 Generated with Claude Code

Port of kasmtech/kasm-helm#29 (matonb). Creates dedicated
components.init_db.annotations and components.init_db.labels
configuration separate from components.api. The db-init-job template
uses this dedicated variable instead of sharing API annotations.

Default value includes helm.sh/hook: pre-install for Helm deployments,
but GitOps/ArgoCD users can override this to remove the hook and
prevent deployment deadlocks.

Upstream-PR: kasmtech/kasm-helm#29
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@darkhonor

Copy link
Copy Markdown
Owner Author

Closing: superseded by upstream kasmtech/kasm-helm 1.1190.7 (Kasm 1.19.0), which addresses this natively. We're retiring the forked charts/kasm chart from this repo and deploying the upstream chart (https://helm.kasm.com) directly via Fleet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant