Repository navigation
Conversation
Author
|
I wanted to share a quick demo to better illustrate the issue I described in the PR description. Sample diff: diff --git c/logo.png i/logo.png
new file mode 100644
index 0000000..f69082d
Binary files /dev/null and i/logo.png differdemo.webm |
abobov
force-pushed
the
fix-binary-file-hyperlinks
branch
from
March 20, 2026 18:23
c4a56fc to
26154ed
Compare
Author
|
Hi @dandavison! This PR is ready for review. Please let me know if it's okay to merge or if any changes are needed. Thanks! |
abobov
force-pushed
the
fix-binary-file-hyperlinks
branch
from
August 27, 2026 04:38
26154ed to
3917456
Compare
When viewing diffs of binary files with hyperlinks enabled, the "(binary file)" suffix was incorrectly included as part of the filename in hyperlinks. This caused links to point to non-existent file paths (e.g., "image.png (binary file)" instead of just "image.png"). The fix introduces a dedicated flag to track binary files separately, builds the hyperlinks using the clean file paths, and only then appends the "(binary file)" indicator outside the hyperlink. This ensures file links work correctly while still providing the binary file indication.
abobov
force-pushed
the
fix-binary-file-hyperlinks
branch
from
October 6, 2026 04:25
3917456 to
2a814a3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
I noticed a small issue with hyperlinks when viewing diffs of binary files. When
--hyperlinksis enabled, binary files show a suffix(binary file)in their filename. However, this suffix was being included as part of the filename in the hyperlink, making the links point to non-existent paths.For example, a binary file named
logo.pngwould generate a hyperlink tologo.png (binary file)instead of justlogo.png. This makes the link unusable since that exact path doesn't exist in the repository.Solution
I've fixed this by:
binary_filesflag to track binary status separately(binary file)indicator after the hyperlink is createdThis ensures hyperlinks point to the actual file paths while still clearly indicating they're binary files.
This is my first contribution to a Rust project, and I'm excited to help improve delta! I'd appreciate any feedback on the implementation. Thanks for creating such an incredible tool that makes my daily development work so much better! 🚀