feat(tools): render fact strip on tool page - #6518
Open
rebelchris wants to merge 1 commit into
Open
Conversation
Fetches DatasetTool.facts via a separate query (same deploy-window
pattern as officialSource/claimedBy) so the not-yet-deployed API can't
500 the page. Renders the description fact as a one-line subtitle
under the H1, a quiet pricing/license/integrations strip under the
hero chip row with source links, and a provenance caption ("checked
{relative date} · See something wrong?") that mailtos support@daily.dev
for corrections.
Pairs with daily-api feat/tool-facts (deploys first).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getToolFacts(slug)topackages/shared/src/graphql/tools.ts, fetched as a separate query ingetStaticPropswith.catch(() => [])— same deploy-window pattern asofficialSource/claimedBy, so a not-yet-deployedfactsfield can't 500 the page.descriptionfact as a one-line subtitle under the H1 (secondary color, single line).pricingModel,license, orintegrationsexists):Pricing · Freemium,License · MIT,Integrates with · X, Y, Z. Enum values are human-cased (open-core→Open core); each value links to itssourceUrlwhen present.From public docs · checked {relative date} · See something wrong?, using the newestverifiedAtacross facts and the existingpublishTimeRelativeShorthelper. The correction link mailtossupport@daily.dev(existing app-wide support address) with a prefilled subjectTool page correction: {tool title}.Pairs with daily-api
feat/tool-facts(API deploys first; this page tolerates the deploy window sincefactsis fetched separately and swallowed on error).Test plan
node ./scripts/typecheck-strict-changed.jspasseseslint --max-warnings=0clean on both changed filespnpm --filter shared test— only the pre-existing 3 locale failures innumberFormat.spec.tspnpm --filter webapp test— only the pre-existingWorldGuideSheet.spec.tsxfailureNEXT_PUBLIC_API_URL=https://api.daily.dev pnpm --filter webapp buildsucceeds against the current production API, which lacksfacts(deploy-window acceptance test)🤖 Generated with Claude Code
Preview domain
https://feat-tool-facts.preview.app.daily.dev