Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README currently suggests all non-numeric cell content throws. Default conversions follow the standard conversion routines and may accept a numeric prefix, so
12abcbecomes 12 and a configured fallback does not apply. Clarify this behavior, add a per-call converter example that rejects unconsumed characters, and explain that disablingmNumericLocaleaffects floating-point conversion only.This addresses the documentation concern acknowledged in #224. Numeric conversion behavior remains as the maintainer requested.
Validation: the exact README callback compiled as C++11 with warnings treated as errors; 18 real public-API checks verified prefixes, fallbacks, locale settings and strict conversion. All 112 official unit tests passed. Independent automated review repeated the example checks and verified that
src/rapidcsv.his unchanged.AI assistance: OpenAI Codex helped inspect the behavior, clarify the documentation and independently validate the example.