Repository navigation
Derive Python paths from $PYTHON_REF instead of hard-coding - #110
Merged
Merged
Conversation
$PYTHON_REF pins 3.14.4 but the local-builder branch of Update-PythonAndPIP still pointed at %ProgramFiles%\Python313. On a machine that has no 3.13 the build dies; worse, on a machine that does (they are not uncommon, this was the previous pinned version) the build silently uses the stale 3.13 interpreter to download wheels, then ships a 3.14 installer alongside them. The offline 'pip install --no-index' on the target then finds only cp313 wheels and fails. Get-PythonVersion parses the version out of $PYTHON_REF and everything version-dependent is derived from it. After the installer runs, both python.exe and pip3.exe are asserted to exist, and the interpreter actually in use is checked against the pinned major.minor -- which turns the 'one should change python version in github action workflows when changed here' comment into an enforced invariant rather than a note.
pashagolub
force-pushed
the
fix/local-python-path
branch
2 times, most recently
from
October 7, 2026 18:43
a9d5703 to
0054c7b
Compare
pashagolub
changed the title
$PYTHON_REF instead of hard-coding
df7cb
approved these changes
Oct 7, 2026
pashagolub
added a commit
that referenced
this pull request
Oct 8, 2026
#110 derived the Python install paths from $PYTHON_REF and put the version in the download log line; this branch routes that same download through Get-VerifiedFile. Kept both: the version-aware message and the hash-verified download.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$PYTHON_REFpins 3.14.4 but the local-builder branch ofUpdate-PythonAndPIPstill pointed at%ProgramFiles%\Python313. On a machine that has no 3.13 the build dies; worse, on a machine that does (they are not uncommon, this was the previous pinned version) the build silently uses the stale 3.13 interpreter to download wheels, then ships a 3.14 installer alongside them. The offlinepip install --no-indexon the target then finds only cp313 wheels and fails.Get-PythonVersionparses the version out of$PYTHON_REFand everything version-dependent is derived from it. After the installer runs, bothpython.exeandpip3.exeare asserted to exist, and the interpreter actually in use is checked against the pinned major.minor -- which turns the 'one should change python version in github action workflows when changed here' comment into an enforced invariant rather than a note.