Repository navigation
Changelog gives the 0.5.0 handshake error sizes as 0.5.0 builds them (#42) - #43
Merged
Merged
Conversation
…42) Three 0.5.0 entries gave sizes for the error of a scan that completed no TLS handshake that were measured before that error gained its sentence about cipher suites (#34), which made each of those errors 28 bytes longer. Against a local server on 127.0.0.1 and ::1 that answers every ClientHello with a handshake_failure alert, `tlsanalyzer 127.0.0.1:47125` printed a 426-byte error, `tlsanalyzer '[::1]:47125'` a 418-byte one, and the first under GODEBUG=fips140=on,tlsmlkem=0 a 495-byte one, where the entries said 398, 390 and 467. Both commands fit for a host name and port of up to 39 characters, where the entry said 49: a 39-character host name and port got both in 498 bytes and a 40-character one got one. For an IPv6 address and port the limit is 38, where the entry said 47: a 38-character one got both in 499 bytes and a 39-character one got one. The entries now give those figures, name the alert they were measured after, and say that an error whose commands all fit names the groups only in its commands, in place of "byte for byte the same as before". The third entry's statement that scanner-target-example.localhost under that GODEBUG setting, and a 51-character host name without it, get the command for the first group still holds: each error gave that one command. TestTheChangelogGivesTheHandshakeFailureSizesThisTreeBuilds builds the error with handshakeFailureMessage and checks the figures the 0.5.0 section gives: the three sizes, and the longest host name and port (7 to 259 bytes) and IPv6 address and port (23 to 63 bytes) for which both commands fit. It reports 4 errors on the changelog this commit replaces, 4 errors on the code from before the cipher suite sentence (876b7d0) with the new changelog, and passes here. It is skipped once a section other than 0.5.0 opens the changelog. Fixes #42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request lands 1 commit in
CHANGELOG.mdandinternal/scanner.Included
Verified on this exact tree
go version: go1.26.3 darwin/arm64git ls-files --others -- '*_test.go': no output;git ls-files -- '*_test.go' | wc -l: 103go mod verify: all modules verifiedgo build ./...: exit 0go vet ./...: exit 0gofmt -s -l .: no output (0 lines)golangci-lint run -j 4 --timeout=5m ./...(golangci-lint 2.12.2, emptyGOLANGCI_LINT_CACHEdirectory): exit 0, 0 issuesgo test -race -p 4 -count=1 -v -skip '^TestAZoneScopedLinkLocalTargetIsScanned$' ./...: exit 0, 6 of 6 packages ok--- PASSlines, 0--- FAILlines, 1--- SKIPline (TestFIPSChildScanNamesTheHybridGroupsItCannotOffer), counted at top level; 961 PASS, 0 FAIL and 1 SKIP including subtests--- PASS: TestTheChangelogGivesTheHandshakeFailureSizesThisTreeBuildsTestAZoneScopedLinkLocalTargetIsScanned(excluded by the-skipabove; it listens on a link-local IPv6 address)Not included
None
Closes
Fixes #42
How to merge
Rebase and merge, so that each change stays its own commit on
main.