Repository navigation
Stage 0.5.0: source builds report 0.5.0, changelog retitled, README sample re-run, FIPS entry corrected (#33) - #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request lands 1 commit in
cmd/tlsanalyzer,internal/scanner,CHANGELOG.mdandREADME.md.Included
Verified on this exact tree
go mod verify:all modules verified.go build ./...: exit 0, no output.go vet ./...: exit 0, no output.gofmt -s -l .: 0 files listed.git ls-files --others -- '*_test.go': 0 untracked test files;git ls-files -- '*_test.go' | wc -l: 93.go test -race -p 4 -count=1 -json ./...: exit 0; packages: 6 pass, 0 fail; tests including subtests: 930 pass, 0 fail, 1 skip; top-level tests: 403 pass, 0 fail, 1 skip.TestFIPSChildScanNamesTheHybridGroupsItCannotOfferininternal/scanner; its output:client_hello_written_test.go:105: runs in the child process that TestAFIPSBuildWithoutMLKEMNamesTheHybridGroupsItCannotOffer starts.TestVersionIsTheNewestChangelogRelease(added by this commit): pass.Not included
None
Closes
Fixes #33
How to merge
Rebase and merge, so that each change stays its own commit on
main.