Skip to content

fix(gpg-verify): prefix gpgv --keyring with gnupg-ring: for Windows paths - #88

Open
wnoonan wants to merge 1 commit into
criblio:masterfrom
wnoonan:wnoonan/bug/INFRA-11554
Open

fix(gpg-verify): prefix gpgv --keyring with gnupg-ring: for Windows paths#88
wnoonan wants to merge 1 commit into
criblio:masterfrom
wnoonan:wnoonan/bug/INFRA-11554

Conversation

@wnoonan

@wnoonan wnoonan commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

What

Prefix the gpgv --keyring argument with gnupg-ring: so signature verification works on Windows.

Why

The verify-on-download path runs gpgv --keyring <path>. On Windows the keyring lives at a drive-letter path (C:/...), and gpgv reads the leading C: as a URL scheme, failing with invalid key resource URL 'C:/...'. Broke Windows builds pulling js2bin#master.

Fix

gnupg-ring: tells gpgv the value is a literal keyring filename, not a URL. No-op on POSIX paths.

Test

Added a regression test that puts the keyring under a colon-prefixed dir, reproducing the misparse on any platform. All 7 tests pass

@theothergraham

Copy link
Copy Markdown
Contributor

I verified this fix works for me on the host where I ran into the issue. Others are not seeing the issue and I have been unable to figure out why, but this look like a safe fix to me.

@avcribl avcribl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants