fix(gpg-verify): prefix gpgv --keyring with gnupg-ring: for Windows paths - #88
Open
wnoonan wants to merge 1 commit into
Open
fix(gpg-verify): prefix gpgv --keyring with gnupg-ring: for Windows paths#88wnoonan wants to merge 1 commit into
wnoonan wants to merge 1 commit into
Conversation
Contributor
|
I verified this fix works for me on the host where I ran into the issue. Others are not seeing the issue and I have been unable to figure out why, but this look like a safe fix to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prefix the gpgv
--keyringargument withgnupg-ring:so signature verification works on Windows.Why
The verify-on-download path runs
gpgv --keyring <path>. On Windows the keyring lives at a drive-letter path (C:/...), and gpgv reads the leadingC:as a URL scheme, failing withinvalid key resource URL 'C:/...'. Broke Windows builds pulling js2bin#master.Fix
gnupg-ring:tells gpgv the value is a literal keyring filename, not a URL. No-op on POSIX paths.Test
Added a regression test that puts the keyring under a colon-prefixed dir, reproducing the misparse on any platform. All 7 tests pass