SystemUI: Disable tile squishiness animation during QS expansion#1321
Closed
iusmac wants to merge 961 commits into
Closed
SystemUI: Disable tile squishiness animation during QS expansion#1321iusmac wants to merge 961 commits into
iusmac wants to merge 961 commits into
Conversation
* Iterating the mutable listeners list during configuration dispatch causes below crash 12-09 21:15:07.361 D/AndroidRuntime(2214): Shutting down VM 12-09 21:15:07.361 E/AndroidRuntime(2214): FATAL EXCEPTION: main 12-09 21:15:07.361 E/AndroidRuntime(2214): Process: com.android.systemui, PID: 2214 12-09 21:15:07.361 E/AndroidRuntime(2214): java.util.ConcurrentModificationException 12-09 21:15:07.361 E/AndroidRuntime(2214): at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1111) 12-09 21:15:07.361 E/AndroidRuntime(2214): at java.util.ArrayList$Itr.next(ArrayList.java:1064) 12-09 21:15:07.361 E/AndroidRuntime(2214): at kotlin.collections.CollectionsKt.filterNotNull(Unknown Source:16) 12-09 21:15:07.361 E/AndroidRuntime(2214): at com.android.systemui.statusbar.phone.ConfigurationControllerImpl.onConfigurationChanged(go/retraceme d43d4e7a8dd5b2e7eba70ac5852a31df7ec95eb6ed6791527c5ce29550f31e4c:30) 12-09 21:15:07.361 E/AndroidRuntime(2214): at com.android.systemui.SystemUIApplication.onConfigurationChanged(go/retraceme d43d4e7a8dd5b2e7eba70ac5852a31df7ec95eb6ed6791527c5ce29550f31e4c:36) 12-09 21:15:07.361 E/AndroidRuntime(2214): at android.app.ConfigurationController.performConfigurationChanged(ConfigurationController.java:261) 12-09 21:15:07.361 E/AndroidRuntime(2214): at android.app.ConfigurationController.handleConfigurationChangedInner(ConfigurationController.java:235) 12-09 21:15:07.361 E/AndroidRuntime(2214): at android.app.ConfigurationController.handleConfigurationChanged(ConfigurationController.java:154) 12-09 21:15:07.361 E/AndroidRuntime(2214): at android.app.ConfigurationController.handleConfigurationChanged(ConfigurationController.java:129) 12-09 21:15:07.361 E/AndroidRuntime(2214): at android.app.ActivityThread.handleConfigurationChanged(ActivityThread.java:6948) 12-09 21:15:07.361 E/AndroidRuntime(2214): at android.app.servertransaction.ConfigurationChangeItem.execute(ConfigurationChangeItem.java:56) 12-09 21:15:07.361 E/AndroidRuntime(2214): at android.app.servertransaction.TransactionExecutor.executeNonLifecycleItem(TransactionExecutor.java:133) 12-09 21:15:07.361 E/AndroidRuntime(2214): at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:103) 12-09 21:15:07.361 E/AndroidRuntime(2214): at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:80) 12-09 21:15:07.361 E/AndroidRuntime(2214): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2831) 12-09 21:15:07.361 E/AndroidRuntime(2214): at android.os.Handler.dispatchMessage(Handler.java:110) 12-09 21:15:07.361 E/AndroidRuntime(2214): at android.os.Looper.dispatchMessage(Looper.java:315) 12-09 21:15:07.361 E/AndroidRuntime(2214): at android.os.Looper.loopOnce(Looper.java:251) 12-09 21:15:07.361 E/AndroidRuntime(2214): at android.os.Looper.loop(Looper.java:349) 12-09 21:15:07.361 E/AndroidRuntime(2214): at android.app.ActivityThread.main(ActivityThread.java:9047) 12-09 21:15:07.361 E/AndroidRuntime(2214): at java.lang.reflect.Method.invoke(Native Method) 12-09 21:15:07.361 E/AndroidRuntime(2214): at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:596) 12-09 21:15:07.361 E/AndroidRuntime(2214): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:929) Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
* As listener could be null, apply filterNotNull to avoid it Log: 12-14 17:58:13.733 3663 3663 E AndroidRuntime: FATAL EXCEPTION: main 12-14 17:58:13.733 3663 3663 E AndroidRuntime: Process: com.android.systemui, PID: 3663 12-14 17:58:13.733 3663 3663 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke interface method 'void com.android.systemui.statusbar.policy.ConfigurationController$ConfigurationListener.onConfigChanged(android.content.res.Configuration)' on a null object reference 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at com.android.systemui.statusbar.phone.ConfigurationControllerImpl.onConfigurationChanged(ConfigurationControllerImpl.kt:74) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at com.android.systemui.SystemUIApplication.onConfigurationChanged(SystemUIApplication.java:449) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at android.app.ConfigurationController.performConfigurationChanged(ConfigurationController.java:242) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at android.app.ConfigurationController.handleConfigurationChanged(ConfigurationController.java:216) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at android.app.ConfigurationController.handleConfigurationChanged(ConfigurationController.java:128) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at android.app.ActivityThread.handleConfigurationChanged(ActivityThread.java:6520) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at android.app.servertransaction.ConfigurationChangeItem.execute(ConfigurationChangeItem.java:48) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at android.app.servertransaction.TransactionExecutor.executeNonLifecycleItem(TransactionExecutor.java:231) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:152) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:93) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2595) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:107) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at android.os.Looper.loopOnce(Looper.java:232) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at android.os.Looper.loop(Looper.java:317) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:8597) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:583) 12-14 17:58:13.733 3663 3663 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878) neobuddy89: Ensure these checks for all listeners and during callbacks. Change-Id: I1b5197667f7837dcabd67204ae6b764113dbbcce Co-authored-by: Pranav Vashi <neobuddy89@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I4ea5385caf72336bd8fbc87f85e3e00e85d189d2 Signed-off-by: rmp22 <195054967+rmp22@users.noreply.github.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I4f4087b3b379ba60872c92f62bc4107dfce37f7e Signed-off-by: rmp22 <195054967+rmp22@users.noreply.github.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
- Inspired from Lunaris-AOSP/frameworks_base_old@57f26ed Signed-off-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Address a bug where complex resources (Styles, arrays, etc) can use resource references (<item type=...) but at runtime they would not be found. When getting a Bag check for the resource being a reference and recursively resolve the reference. Added tests to AssetManager2_test which verify the functionality. The 2 alias tests failed prior to the change but pass now. Bug: 480904335 Test: AssetManager2_test Change-Id: Ie6b8740558e566056c3a4acbfe9201b3f43bdac8
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: Ib9f9cd63713946004fb0f0e7622de572f1b2431c Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
A malformed event can cause an NPE in CriticalEventLog.saveLogToFileNow() when CriticalEventLogStorageProto.toByteArray() calls computeSerializedSize() on an event with null fields. This leads to a crash system_server and will force a device reboot. Move the toByteArray() call into the try-with-resources block and broaden the catch from IOException to Exception so that any exception during serialization or writing is caught and logged rather than crashing the system_server. Bug: None Test: atest CriticalEventLogTest Change-Id: I57190fc3245f9f03950f0cf7597fa3d4d2a5b550
Change-Id: I25755bded0e38fb5f43f49e70126ee5d73a2856d Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Test: Screen record notification will flicker on expansion. Reason: Override tint color was reset on expansion. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I7a4c3b55b073b82beb24d079681b585f93c64f70 Signed-off-by: SuperDroidBond <superdroidbond@yahoo.com>
It is not necessary to use this for all devices, but only for those that have a problem with charging display (for example OnePlus 7 series) Change-Id: I98441087ec450ec3a2699a1a79b84bc32a1fe340 Co-authored-by: Pranav Vashi <neobuddy89@gmail.com>
During the use of makeSceneTransitionAnimation(), two ExitTransitionCoordinator instances are generated, corresponding to the activity before the transition and the activity after the transition, respectively. The activity after the transition is released after finishing() when finishAfterTransition() is called. However, the activity before the transition is leaked in ExitTransitionCoordinator because mExitCallbacks holds it and cannot be released.. We found that the reason why the activity before the transition cannot reach finish() is that mIsReturning is always false.Therefore, we modified finishIfNecessary() to release the activity to avoid the leak. Change-Id: I795f4c85ebb85a5fb8448738e127f7b07cf8ef35
Signed-off-by: Ghosuto <clash.raja10@gmail.com> [neobuddy89: Completely remove doze dependencies.] Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
* Polling every 5 seconds is wasteful. Use MutableStateFlow instead. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
The variable mEglContext was incorrectly declared as EGLDisplay, which is a type mismatch. This commit corrects the type to EGLContext to accurately represent the EGL rendering context. Bug:493359405 Change-Id: I2488ac4de10e0498328c4f67fccd9bbb2af150ac Signed-off-by: zhangzhihao6@xiaomi.com <zhangzhihao6@xiaomi.corp-partner.google.com>
The Wi-Fi QS tile currently shows the mobile network description when Wi-Fi is inactive and mobile data is the default connection. This makes the tile subtitle describe mobile data state instead of Wi-Fi state. Use the existing Wi-Fi fallback subtitle for inactive Wi-Fi states so the tile remains Wi-Fi-specific. Change-Id: Iaed44551664723975a399e829245a4524e51a80c Signed-off-by: Ashwin Devi Srinivasan <astroashwin@outlook.com>
Signed-off-by: minaripenguin <minaripenguin@users.noreply.github.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Ghosuto: Adapt weather view to updated omnijaw controller neobuddy89: Clean up unnecessary changes Signed-off-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
@neobuddy89: Various clean ups and adapt for our weather impl. Co-authored-by: Pranav Vashi <neobuddy89@gmail.com> Co-authored-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Co-authored-by: Lixkote <95425619+Lixkote@users.noreply.github.com> Co-authored-by: kshitij-bhale <156404280+kshitij-bhale@users.noreply.github.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
it's not fair to display NR_NSA same as we display NR_SA Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I38c307a292e4ce84436bbe670c363d8cd5581283 Signed-off-by: kleidione <kleidione@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
The clock only animated its doze amount for AOD <-> LOCKSCREEN, so any transition through DOZING (e.g. pulsing notifications with AOD off) snapped the clock between dozed and lockscreen states instead of interpolating. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
* Also fix an AudioPlaybackCallback leak when attach fails. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: Ife1978da30fa167bcbec1fc66f138802cf1aef6f Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
* get badged icon for managed user Change-Id: I52274ff52132e6b0b8a430a2f9ca8ef070458efb Signed-off-by: someone5678 <59456192+someone5678@users.noreply.github.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I13850be2303d8a6f6aac28e121bc311057a64b98 Co-authored-by: DP <dprietob@users.noreply.hosted.weblate.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Sasha Glazko <lenify@tutanota.com> Co-authored-by: vdsvtsl <vdsvtsl@gmail.com> Translate-URL: https://hosted.weblate.org/projects/calyxos/platform_frameworks_base/be/ Translate-URL: https://hosted.weblate.org/projects/calyxos/platform_frameworks_base/es/ Translate-URL: https://hosted.weblate.org/projects/calyxos/platform_frameworks_base/uk/ Translate-URL: https://hosted.weblate.org/projects/calyxos/platform_frameworks_base_systemui/be/ Translate-URL: https://hosted.weblate.org/projects/calyxos/platform_frameworks_base_systemui/uk/ Translation: CalyxOS/Battery stats Translation: CalyxOS/SystemUI Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
…e same task LOCK_BEHAVIOR_ON_LEAVE re-locked an unlocked app whenever focus moved to a different package. But activities started for a result (e.g. the MediaStore delete/trash confirmation that Google Photos launches) live in the caller's own task, so this fired even though the user never left the app, forcing a second auth prompt on return. Track the unlocked app's task id and, in onAppFocusChanged, skip the ON_LEAVE re-lock when focus stays within that same task. The app's tracking is kept pointing at the real package (not the transient sub-activity) so a genuine task switch still re-locks correctly. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: Ia3ba842e124e1aacf083ea461b6d3c45a9a3bc65 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
… old FlashlightController implementation Signed-off-by: NurKeinNeid <nurkeinneid@derpfest.org> Signed-off-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Direct secondary-click expansion could choose the wrong slider backend due to controller-state timing, which caused the slider to show 0% while torch was being enabled. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
When legacy flashlight slider moves from 0 to a positive level, enable flashlight before applying strength level. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Allow the dynamic bar flashlight slider to include 0 so users can turn the torch off without dismissing the controls. While the torch is off from the slider, keep the torch event visible at 0% so sliding upward can re-enable the light. Dismiss and stop actions now clear the retained event and only toggle the torch when it is actually on, so pressing stop at 0% does not turn it back on. When re-enabling from 0%, only call setEnabled(true) for the remembered-level no-op case; otherwise let setLevel() or setTemporaryLevel() turn the torch on at the requested strength to avoid racing back to the default level. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: Ia3ab65e8d89d3fd6dc1933da22feb3a83179635c Signed-off-by: rmp22 <195054967+rmp22@users.noreply.github.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: Ib7789db0bd64a2bbefc7cb3fc8fbc6f861008852 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
* This will stop squishing the vertical bounds of the QS tiles like Internet/Bluetooth during QS expansion. Fixes: crdroidandroid/issue_tracker#1028 Fixes: crdroidandroid/issue_tracker#992 Signed-off-by: iusmac <iusico.maxim@libero.it>
iusmac
force-pushed
the
systemui-disable-tile-squishiness-animation-during-qs-expansion
branch
from
e4ff115 to
a68046d
Compare
Member
|
Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: crdroidandroid/issue_tracker#1028
Fixes: crdroidandroid/issue_tracker#992