Fix hosted CI Python collection and macOS/Linux hash parity - #1
Merged
Conversation
Unit jobs install the Python package without Stable-Baselines3, so skip SB3-only collection there. Round hashed finite numbers to 12 decimals so independently resolved IGVC worlds keep the same identity hashes across CPU libm implementations. Co-authored-by: Cursor <cursoragent@cursor.com>
Twelve-decimal rounding left Mercator cancellation in macOS/Linux hashes and broke Python rfc8785 checks. Quantize hashed numbers to six decimals, round resolvedHash inputs without changing canonical JSON, and install Node in the Python unit matrix. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./python[test]without Stable-Baselines3; skip collectingtest_integration.pyin that environment and keep the VecEnv seed check behindimportorskip.resolvedHash/simulationSemanticHash/episodeHashon linux-x64 and darwin-arm64.Math.PI.Test plan
python -m pytest -m 'not integration' python/testsin a venv withoutstable_baselines3(30 passed, 1 skipped, integration file not collected)npm test(636 passed, 2 skipped)npm run lint/npm run lint:pythonMade with Cursor