Evaluate real TeX documents and fix concessive comparison warnings - #406
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real TeX manuscripts expose gaps that generated acceptance cases miss. This change collects five pinned arXiv papers across five fields (21 TeX files) and evaluates 15 definition destinations recorded from the sources before consulting the engine. Full source inventories remain local; versioned metadata, hashes, annotations, bounded collection, and native/WASM evaluation make the results reproducible.
The evaluation found a false comparison warning in the Transformer paper: a concessive
Even with k=ncase became a global fact conflicting withk<n. Treat concessive conditions as conditional evidence, with a failing-then-passing Rust regression and real TeX/Markdown acceptance coverage. Ship matching Linux-built WASM as 0.19.2 without a protocol change.Current navigation outcomes are 4 correct, 8 abstentions, and 3 tasks blocked by a syntax rejection; no returned destination was wrong. The original warning disappears. Rename probes and six remaining definition-hygiene hints are observations pending further review, not claimed accuracy. These are agent-authored development tasks, not a blind benchmark or author usability study.
Validation: exact committed candidate
4dd7bcb773c4b0f2ac97e219a8880db118266261passed x86_64 Linuxbun run release:check, includingcheck,quality, documentation lint, package smoke, and byte-identical rebuilt WASM. GitHub CI passed. Original-document evaluation passed native/WASM comparisons for four accepted papers and confirmed the same rejection for the fifth. The clean-source run retained all 15 tasks.Retired the obsolete #345 and #354 plans as not planned. Concrete remaining scope/definition work is tracked in #405.