[codex] fix continuity decision domain - #398
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The release continuity gate treated the established cursor entity
Aas if it were the selected formulaAx. The engine correctly reported the entity as established and the formula as conflicting, but the legacy single-domain scorer classified that separation as a false establishment.This keeps the formula-conflict expectation intact while making the compared decision domain explicit.
Validation
bun test packages/evaluation/src/semantic-continuity.test.ts packages/evaluation/src/semantic-continuity-release.test.tsbun run continuity:release— 42/48, risk 12, no unsafe classbun run typecheckgit diff --checkbun run checkpassed through tests, fixtures, conformance, and native/WASM parity; local macOS arm64 RSS budget remained at the known ~152 MB versus the 117 MB Linux gate and will be verified by CI