Skip to content

[codex] fix continuity decision domain - #398

Merged
akcorca merged 1 commit into
mainfrom
codex/fix-continuity-decision-domain
Aug 26, 2026
Merged

akcorca merged 1 commit into
mainfrom
codex/fix-continuity-decision-domain

Conversation

@akcorca

@akcorca akcorca commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • record the selected-formula authoring disposition alongside the cursor-entity decision in semantic-continuity observations
  • explicitly route the reviewed product-shape conflict case to the selected-formula decision domain
  • fail closed for unknown, duplicate, or incompatible formula-domain selections

Why

The release continuity gate treated the established cursor entity A as if it were the selected formula Ax. The engine correctly reported the entity as established and the formula as conflicting, but the legacy single-domain scorer classified that separation as a false establishment.

This keeps the formula-conflict expectation intact while making the compared decision domain explicit.

Validation

  • bun test packages/evaluation/src/semantic-continuity.test.ts packages/evaluation/src/semantic-continuity-release.test.ts
  • bun run continuity:release — 42/48, risk 12, no unsafe class
  • bun run typecheck
  • git diff --check
  • bun run check passed through tests, fixtures, conformance, and native/WASM parity; local macOS arm64 RSS budget remained at the known ~152 MB versus the 117 MB Linux gate and will be verified by CI

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 89f8f6f5-27be-4d0d-a7f0-504354a0f9bc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@akcorca
akcorca merged commit 1df56a8 into main Aug 26, 2026
2 checks passed
@akcorca
akcorca deleted the codex/fix-continuity-decision-domain branch August 26, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant