Repository navigation
test: retain work-limit evidence after diagnostic timeout - #119
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A work-limit failure can reach
E2BIGjust before the deadline expires. The deadline then refuses stderr I/O, leaving an empty diagnostic while the execution event correctly retains the originalE2BIGcode. The external watchdog check now accepts that structured code alongsideETIMEDOUT; it still requires a nonzero exit and rejects unrelated failures.Reproduced the failed assertion on Node 24 by advancing the injected clock immediately after the work-limit event. Both that reproduction and all 14 normal isolated checks pass after this change. Formatting and diff checks pass. Execution limits and external watchdog durations are unchanged.