Skip to content

test: retain work-limit evidence after diagnostic timeout - #119

Merged
akcorca merged 1 commit into
mainfrom
fix/release-limit-diagnostics
Sep 5, 2026
Merged

akcorca merged 1 commit into
mainfrom
fix/release-limit-diagnostics

Conversation

@akcorca

@akcorca akcorca commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

A work-limit failure can reach E2BIG just before the deadline expires. The deadline then refuses stderr I/O, leaving an empty diagnostic while the execution event correctly retains the original E2BIG code. The external watchdog check now accepts that structured code alongside ETIMEDOUT; it still requires a nonzero exit and rejects unrelated failures.

Reproduced the failed assertion on Node 24 by advancing the injected clock immediately after the work-limit event. Both that reproduction and all 14 normal isolated checks pass after this change. Formatting and diff checks pass. Execution limits and external watchdog durations are unchanged.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 0c8e75bc-58d9-455b-b2c9-6fefaaec28c5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@akcorca
akcorca merged commit 6519519 into main Sep 5, 2026
3 checks passed
@akcorca
akcorca deleted the fix/release-limit-diagnostics branch September 5, 2026 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant