Skip to content

fix: bump 0 deps to resolve Snyk vulnerabilities - #16

Merged
cs-raj merged 2 commits into
mainfrom
fix/snyk-patch-deps-20261102
Nov 4, 2026
Merged

cs-raj merged 2 commits into
mainfrom
fix/snyk-patch-deps-20261102

Conversation

@dange-cstk

@dange-cstk dange-cstk commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Open Snyk findings on main: 34 (C/H/M/L 2/16/14/2); npm audit 43.

Fix

This repo is an APP: the lock file is the deliverable, so regenerating it is a real fix and overrides apply to the shipped tree.

  • Lock files regenerated in every root (fixed 31 findings on their own).
  • Direct upgrades (patch/minor, chosen by --safe rules): none
  • Overrides (same-major, production tree, high/critical or ticketed): none
  • i18next-http-backend 3.0.6 → 4.0.9 (separate commit), clearing the SSRF, CRLF-injection and output-injection findings. @spartacus/core 221121 declares a ^3.0.6 peer; the app bundles its translations (no i18n.backend.loadPath), so Spartacus never loads translations over HTTP.
  • Snyk 34 → 0, npm audit 43 → 19 (0 critical, 0 high; 19 moderate left).

Verification

Fresh install in every root, snyk test --all-projects + npm audit re-scan, and npm run build passes (prebuild generate-env + ng build). The build used placeholder CS_API_KEY/CS_DELIVERY_TOKEN values, since it only embeds them in the generated environment file; no .env was written or committed.

Installs need SAP RBSC registry access for @spartacus/* and legacy-peer-deps, as the README describes; the regenerated lock still resolves the 15 Spartacus packages from the same RBSC host, with no credentials in the lock file.

Jira

Removes the Snyk IDs of 31 open DX tickets: DX-12119, DX-12311, DX-26664, DX-26665, DX-26666, DX-26667, DX-26668, DX-26669, DX-26670, DX-26671, DX-26672, DX-26673, DX-26674, DX-26675, DX-28754, DX-28755, DX-28756, DX-28874, DX-29711, DX-30161, DX-30162, DX-30163, DX-30164, DX-31008, DX-31009, DX-31010, DX-31466, DX-31467, DX-31468, DX-31469, DX-31639. 3 remain open. Tickets were not updated by this run.

What remains

  • Snyk: nothing.
  • npm audit: 19 moderate findings, mostly in Angular/Spartacus build tooling.

🤖 Generated with Claude Code

Lock file regenerated (fixed 31 on its own).
Direct upgrades: none
Overrides: none
Vuln count: snyk 34 → 3, npm audit 43 → 20. Build verified passing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@snyk-io

snyk-io Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 2 0 500 ✅ Passed
🔵 Low Severity 1 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

Resolves SNYK-JS-I18NEXTHTTPBACKEND-20580644 (SSRF), -21816473 (CRLF
injection) and -21689179. @spartacus/core 221121 declares a ^3.0.6 peer;
the app bundles its translations (no i18n.backend.loadPath), so the HTTP
backend is not used at runtime. Build passes; Snyk 0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@vaishnavi-kedar-cstk
vaishnavi-kedar-cstk marked this pull request as ready for review November 4, 2026 09:33
@vaishnavi-kedar-cstk
vaishnavi-kedar-cstk requested a review from a team as a code owner November 4, 2026 09:33
@cs-raj
cs-raj merged commit eca98fb into main Nov 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants