Skip to content

feat(secrets): add launch:secrets list, set and unset (CL-8166) - #274

Closed
tejas-contentstack wants to merge 4 commits into
v2-devfrom
CL-8166-v2-dev
Closed

feat(secrets): add launch:secrets list, set and unset (CL-8166)#274
tejas-contentstack wants to merge 4 commits into
v2-devfrom
CL-8166-v2-dev

Conversation

@tejas-contentstack

@tejas-contentstack tejas-contentstack commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@-

Generated by Claude Code

claude added 4 commits October 30, 2026 11:56
@claude
feat(secrets): add launch:secrets:list and the secrets resource found…
b5faee5 
…ation

Adds the secrets resource (SecretsApi over the REST secrets endpoint, error
wording, presenter) wired through resources.ts, and a list command that prints
KEY and UPDATED and never a value.

#claude_code#
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EptZEi8nvDRpqxwsFu2SSa
@claude
feat(secrets): add launch:secrets:set to add or refresh an environmen…
c6fae35 
…t secret

The value is read from a masked prompt on a terminal or from stdin when piped,
never from an argument. It adds, or refreshes through PUT when the key is
already listed, after the confirm gate, and warns for client-exposed prefixes.

#claude_code#
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EptZEi8nvDRpqxwsFu2SSa
@claude
feat(secrets): add launch:secrets:unset to delete environment secrets
d6c1a2b 
Repeatable --key deletes each secret with a DELETE per key in order, behind the
confirm gate; the first failure stops the run, keys already removed keep their
success line. Adds SecretsApi.delete and the unset short name.

#claude_code#
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EptZEi8nvDRpqxwsFu2SSa
@claude
chore(talisman): refresh checksums for src/resources.test.ts, src/sec…
e247ea3 
…rets/secrets.redact.ts, src/secrets/secrets.redact.test.ts, test/guards/layering.test.ts

Four .talismanrc checksums were stale against the committed content of files changed on this branch; replaced only those values with fresh Talisman checksums.

#claude_code#
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EptZEi8nvDRpqxwsFu2SSa
@tejas-contentstack
tejas-contentstack requested review from a team as code owners October 30, 2026 12:28
@snyk-io

snyk-io Bot commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

github-actions Bot commented Oct 30, 2026

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 6 9 25 ✅ Passed
🟡 Medium Severity 0 2 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 9
  • Medium without fixes: 2
  • Low without fixes: 0

✅ BUILD PASSED - All security checks passed

@dhruv-parekh-cs dhruv-parekh-cs mentioned this pull request Oct 30, 2026
Merged
dhruv-parekh-cs
dhruv-parekh-cs reviewed Oct 30, 2026
View reviewed changes

@dhruv-parekh-cs dhruv-parekh-cs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the whole PR: 0 high, 1 medium (cross-repo, below).

Cross-repo (CL-8166): Medium #275 targets the same base (v2-dev) with a separate implementation of the same launch:secrets commands (same src/commands/launch/secrets/* paths, different src/secrets/* modules), and the latest request is for #275. Merging both would conflict or leave two secrets modules behind one set of commands. Close this PR in favour of #275, or say which one is meant to land.

— 🤖 launch-pr-review-agent (Claude)

Generated by Claude Code

@tejas-contentstack Claude

tejas-contentstack commented Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of #275, which implements the same launch:secrets commands on v2-dev and is already approved. Keeping #275 as the one to land; the branch CL-8166-v2-dev is left in place for reference.

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruv-parekh-cs dhruv-parekh-cs dhruv-parekh-cs left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tejas-contentstack @dhruv-parekh-cs @claude