Return 415 from WSGI for unknown GET encoding - #377
Merged
Merged
Conversation
The WSGI server answered a unary GET whose `encoding` query parameter named no configured codec with `unimplemented`, after the metadata interceptors had already started. connect-go and the ASGI server answer 415 with `Accept-Post` before running any interceptors, so resolve the codec up front in `_handle_unary` the way the ASGI server does. Signed-off-by: Stefan VanBuren <stefan@vanburen.xyz>
anuraaga
approved these changes
Sep 30, 2026
| codec = self._codecs.get(codec_name) | ||
| if not codec: | ||
| raise ConnectError( | ||
| Code.UNIMPLEMENTED, f"invalid message encoding: '{codec_name}'" |
Collaborator
There was a problem hiding this comment.
Hmm wonder how that happened
| ) | ||
| codec_name = query_params.get("encoding", ("",))[0] | ||
| else: | ||
| query_params = {} |
Collaborator
There was a problem hiding this comment.
Can you use the singleton unset pattern from async? Or alternatively None and assert is not None in the get path would be fine too
Signed-off-by: Stefan VanBuren <stefan@vanburen.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a Connect unary GET whose
encodingquery parameter is missing or names a codec the server doesn't support, connect-go answers 415 withAccept-Postbefore running any handler logic:connectHandler.CanHandlePayloadmapsencodingto a content type, and the handler returns 415 when no protocol accepts it. The ASGI application already does this; the WSGI application instead answeredunimplementedafter starting the metadata interceptors.The new
test_client_errorscases for an unknown and a missingencodingfail onmainfor WSGI only.