Queue docs deployments instead of racing them - #355
Merged
Merged
Conversation
Two merges two seconds apart started overlapping Documentation runs, and Pages rejected the second deployment because the first was still in progress: https://github.com/connectrpc/connect-py/actions/runs/36135119586/job/108071236285 Put pushes to `main` in one concurrency group that never cancels an in-progress run, so deployments queue. GitHub keeps only the newest pending run per group, which is fine here because it builds the newest commit. PR builds get a group per ref and cancel superseded runs, so they can't displace a queued deployment. Signed-off-by: Stefan VanBuren <stefan@vanburen.xyz>
anuraaga
approved these changes
Sep 25, 2026
| id-token: write | ||
|
|
||
| concurrency: | ||
| # Pages rejects a deployment while another is in progress, so deploys |
Collaborator
There was a problem hiding this comment.
Lately I find Claude generates pretty ridiculous prose that sometimes I can't even read anymore, would appreciate double-checking it in advance
I think this is
# Use a constant key for commits so deployments are queued in order.
# Only cancel for pull requests
Second line being a copy from ci.yaml
Member
Author
There was a problem hiding this comment.
took your suggestion on the first line, and copied over the line directly from ci.yaml for the second line, in 1b43b16. thanks!
Lately I find Claude generates pretty ridiculous prose that sometimes I can't even read anymore, would appreciate double-checking it in advance
Agreed, and will do. Writing Good Comments is still not a solved problem for AI :)
Signed-off-by: Stefan VanBuren <stefan@vanburen.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just to fix the failure we saw in https://github.com/connectrpc/connect-py/actions/runs/36135119586/job/108071236285, from multiple PRs being merged close together.
The PR group is keyed by ref rather than shared because GitHub keeps a single pending run per concurrency group; a shared
pagesgroup, as in GitHub's Pages starter workflows, would let a PR build cancel a deployment waiting behind another one. The effect onmainshows up only when two merges land close together, so this PR's own docs build exercises only the PR branch of the expression.