feat(create): persist ordered module resources - #183
Draft
kbuffardi wants to merge 1 commit into
Draft
Conversation
Store zero-based ModuleResources ordering, return it across module and course reads, and make resource selection sortable and removable. Order learner Demo attempts by the existing exercise order.\n\nCloses #182
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #182
Verification
npx tsc -p api/tsconfig.app.json --noEmitnpx tsc -p client/tsconfig.app.json --noEmitnpx nx build api --configuration=productionnpx nx build client --configuration=productionTest limitation
The validations library has no configured Nx test target. The Cypress scenario was added, but local browser execution cannot reach the protected Create route without the API/auth service, so it times out before the form mounts.
Security note
npm audit --omit=dev --audit-level=highreports pre-existing repository-wide vulnerabilities, including a critical Sequelize advisory; no dependency changes are included in this PR.