Repository navigation
Native open/save file dialogs with platform hints, options and preview - #6052
shai-almog wants to merge 32 commits into
Conversation
… previews Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…review Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…download Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d options Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Open uses initForOpeningContentTypes (filter UTTypes, extensions, folder), multi-select, directoryURL and shouldShowFileExtensions; picked items are copied to tmp. Save stages content in the caches dir off the EDT and exports it with initForExportingURLs asCopy. Results return through a per-request id and are delivered on the EDT. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…filters, options and hints Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Filters become an accessory popup that switches the allowed types, options render as checkbox/popup/text controls in the same accessory stack, and the MAC_* hints map to the panel properties. Answers use NativeFileDialogCodec; saves are written through completeSaveDialog. No accessory Component or preview on the Mac yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Compared 12 screenshots: 12 matched. |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
|
Developer Guide build artifacts are available for download from this workflow run:
Developer Guide quality checks: |
Cloudflare Preview
|
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Compared 214 screenshots: 214 matched. |
|
Compared 178 screenshots: 178 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
Benchmark ResultsDetailed Performance Metrics
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71c2a5a6ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Compared 193 screenshots: 193 matched. Benchmark ResultsDetailed Performance Metrics
|
- Copyright headers on the new tests; classify the fallback save form in FrameworkChromeNeverWindowsTest; Vale quote punctuation in the guide. - Linux: add the filter's extension in the GTK native and confirm the overwrite of that name, since GTK only checked the typed basename. - Core: saving a sourceFile onto itself no longer truncates it. - Android: refuse to launch while another activity result is outstanding; stop reporting INITIAL_DIRECTORY, which only the URI hint honours. - iOS: convert extension filters to legacy UTIs before iOS 14; copy picked documents off the main thread. - JavaScript: report a dismissed picker as cancelled; a save too large for the heap still answers the callback. - Linux/Windows: deliver results on the EDT. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6b20e3220
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Compared 193 screenshots: 193 matched. Benchmark ResultsDetailed Performance Metrics
ParparVM vs HotSpot (JDK 25): windows-x64The performance gate could not run: the gate's own unit tests (test_perf_gate.py) failed. See |
- Core: a content writer still runs when the destination is the source file; the default implementation no longer advertises INITIAL_DIRECTORY. - JavaSE: filtered saves (and filtered opens on Windows, where AWT's FilenameFilter does nothing) use the Swing chooser, which confirms the overwrite of the name with the extension added. - Android: picks are checked against extension filters the MIME query could not express; a picked folder is copied to the cache so the result is a path FileSystemStorage can use. - macOS: filters given as UTIs reach allowedFileTypes. - iOS: close the staged export stream in a finally (SpotBugs DLS). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7879337058
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Windows: an IFileDialogEvents sink keeps the save dialog's default extension on the selected filter, so switching type no longer yields report.pdf.png. - Core: the fallback save form runs on the EDT when called from another thread, and the open fallback delivers on the EDT. - JavaSE: drop a preview render that finishes after the selection moved; parse file:/ and drive-letter URLs for the starting folder; saves that must not confirm an overwrite use the Swing chooser. - iOS: watchOS and tvOS use the Codename One fallback; a picker requested while another controller is presented answers cancelled instead of hanging. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7802299d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…heck; report fallback save controls Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b00046ab9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…lti-select, boolean hint default Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26ad8056fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…gate, JavaSE URL dirs, Android partial-save cleanup Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f69b8e950
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… successful write Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31852b9dda
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cfb4b397b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ard and coordinated copy, unchecked writer failures Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90ee77db25
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… failure, wildcard fallback accept Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f37784b340
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…e accept union Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
…parators Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Compared 179 screenshots: 179 matched. Benchmark Results
Detailed Performance Metrics
ParparVM vs HotSpot (JDK 25): macos-arm64The performance gate could not run: the gate's own unit tests (test_perf_gate.py) failed. See |
1 participant
Adds native save dialogs, plus open dialogs you can customize, in the new package
com.codename1.io.filechooser.API
Display.showOpenDialog(OpenFileRequest, cb)andDisplay.showSaveDialog(SaveFileRequest, cb). The callback runs on the EDT, including when the user cancels.FileTypeFilter: extensions, MIME types, UTTypes), a suggested name, multi-select or folder picking, and overwrite confirmation.FileDialogOptions (checkbox, choice, text) show up inside the native dialog where the platform allows it, and their values come back inFileDialogResult.FileDialogHintsare platform hints (macOS tag field, Windows client GUID, Android initial URI, ...). A platform ignores the hints it doesn't know.FilePreviewProvidergives a live preview while opening. An accessoryComponentcan be added too.SaveContent(written after the user picks a location and format) or from an existing file.Display.isFileDialogFeatureSupported(...)is a runtime capability query.openFileChooseris unchanged.Ports
FileDialog, or SwingJFileChooserACTION_CREATE_DOCUMENTUIDocumentPickerNSOpenPanelNSSavePanelIFileOpenDialogIFileSaveDialogIFileDialogCustomize, hintsGtkFileChooserGtkFileChooserKnown limitations
allowedFileTypes, which is deprecated on macOS 12 and later, and always confirms before overwriting.Verification
FileDialogRequestTestandFileDialogSupportTest.🤖 Generated with Claude Code