Repository navigation
Preserve starter canary token setup diagnostics - #5926
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The September 30 Linux starter canary timed out during
cn1:set-user-tokenafter 600 seconds, before submitting a cloud build. Its failure report contained no process output because Maven ran with-qand the shipped Maven wrapper defaults to silent downloads. The Windows leg passed in the same run; the Linux timeout's underlying cause is not established.Remove Maven quiet mode for token setup and enable the wrapper's normal verbose output (
MVNW_VERBOSE=true). Existing failure and timeout handling retains the diagnostic tail and redacts the token and account email. Timeouts and failure conditions remain unchanged; this improves diagnosis without claiming to fix an unproven download or service defect.Validation: all 47 canary self-tests pass. Two new subprocess regression tests cover failed and timed-out token setup, assert useful output and credential redaction, and both fail against the original code.
git diff --checkpasses.Related: #5925 and the failed Linux job.
Live verification: rerunning the failed Linux job on unchanged commit
6454b64064b3acc08ec82baf1ec696a9536599dfsucceeded. Token setup took 91 seconds, and JavaScript cloud build1f357f22-7394-4b4a-8d15-18bf10a3225dcompleted successfully (484 seconds end to end). The overall canary is green and its alert job automatically closed #5925. This supports a transient stall; the original quiet log cannot establish its cause. The PR's hosted canary self-test also passed.