Repository navigation
fix(ThemeContext): Prevent empty string in classList.add - #4137
sentry[bot] wants to merge 1 commit into
Conversation
Bundle ReportChanges will increase total bundle size by 71 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
|
The Sentry GitHub App installation for this repository is missing permissions it needs to keep iterating on this pull request to get CI passing. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4137 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15150 +3
Branches 4387 4382 -5
=======================================
+ Hits 14961 14964 +3
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #4137 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15150 +3
Branches 4379 4382 +3
=======================================
+ Hits 14961 14964 +3
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4137 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15150 +3
Branches 4387 4382 -5
=======================================
+ Hits 14961 14964 +3
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Harness.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4137 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15150 +3
Branches 4387 4390 +3
=======================================
+ Hits 14961 14964 +3
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This branch has not been deployed
1 participant
Description
This PR addresses a
SyntaxError: DOMTokenList.add: The empty string is not a valid token.that occurs when thethemevalue retrieved fromlocalStorageis an empty string.The root cause was that
localStorage.getItem('theme')could return an empty string, which was then incorrectly castas Themeand used indocument.body.classList.add(). The nullish coalescing operator??did not prevent this, as it only handlesnullorundefined, not empty strings.Code Example
Notable Changes
The fix involves:
localStorageto ensure it is a validThemeenum member ('light'or'dark'). If not, it defaults tonull.useStateinitializer from??to||(logical OR) to correctly fall back to thesystemThemeif thelocalStoragevalue is an empty string ornull.This ensures that
document.body.classList.add()always receives a valid theme string.Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes GAZEBO-188E
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.