Repository navigation
fix(error-boundary): Prevent TypeError when rendering fallback UI - #4134
sentry[bot] wants to merge 1 commit into
Conversation
|
The Sentry GitHub App installation for this repository is missing permissions it needs to keep iterating on this pull request to get CI passing. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update |
Bundle ReportChanges will increase total bundle size by 184 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4134 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15147
Branches 4387 4379 -8
=======================================
Hits 14961 14961
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #4134 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15147
Branches 4379 4387 +8
=======================================
Hits 14961 14961
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4134 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15147
Branches 4387 4387
=======================================
Hits 14961 14961
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Harness.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4134 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15147
Branches 4387 4387
=======================================
Hits 14961 14961
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This branch has not been deployed
1 participant
Description
This PR addresses a
TypeError: Cannot read properties of undefined (reading 'match')that occurs when theErrorBoundary's fallback UI (DefaultUI) attempts to render.The root cause is that the
ErrorBoundaryis mounted outside the React Router context insrc/index.tsx. TheDefaultUIinsrc/layouts/shared/ErrorBoundary/ErrorBoundary.tsxwas using the router-dependent<A>component, which internally callsuseNavLinks()anduseParams(). WhenuseParams()is called outside a Router,useContext(RouterContext)returnsundefined, leading to theTypeErrorwhen.matchis accessed.The fix involves replacing the
<A to={{ pageName: 'support' }}>component inDefaultUIwith a standard HTML<a href="https://codecovpro.zendesk.com/hc/en-us" target="_blank" rel="noreferrer">tag. This removes the dependency on the React Router for the error boundary's support link, ensuring the fallback UI can render correctly even when an error occurs outside the router's scope.Code Example
N/A
Notable Changes
<A>component with a standard HTML<a>tag inErrorBoundary'sDefaultUI.TypeError: Cannot read properties of undefined (reading 'match')whenErrorBoundaryrenders outside React Router context.ErrorBoundary's fallback UI can render correctly regardless of router context.Screenshots
N/A
Link to Sample Entry
N/A
Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes GAZEBO-15Y6
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.