Skip to content

fix(sentry): Prevent NotFoundError from rrweb DOM patches #4133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sentry): Prevent NotFoundError from rrweb DOM patches #4133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/layouts/LoginLayout/LoginLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const LoginLayout: React.FC<React.PropsWithChildren> = ({ children }) => {
const location = useLocation()

return (
<>
<div className="flex min-h-screen flex-col">
{location.search.includes('expired') && <SessionExpiredBanner />}
<GuestHeader />
<Suspense fallback={<FullPageLoader />}>
Expand All @@ -25,7 +25,7 @@ const LoginLayout: React.FC<React.PropsWithChildren> = ({ children }) => {
</main>
</Suspense>
<Footer />
</>
</div>
)
}

Expand Down
6 changes: 6 additions & 0 deletions src/sentry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ const deClutterConfig = {
// See http://toolbar.conduit.com/Developer/HtmlAndGadget/Methods/JSInjection.aspx
'conduitPage',
...customIgnoredErrors,
// rrweb (Sentry Replay) monkey-patches DOM methods and can conflict with
// React's reconciler when its initialization fails (e.g. adoptedStyleSheets
// already defined by a browser extension). These errors are third-party
// DOM conflicts, not app bugs.
/Failed to execute 'insertBefore' on 'Node'/,
/Failed to execute 'removeChild' on 'Node'/,
],
denyUrls: [
// Facebook flakiness
Expand Down
Loading