fix: prevent large playlist handler from interfering with YouTube queue autoplay (Fixes #4228) - #4263
Open
waterWang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4228
Problem
When the extension is enabled, YouTube keeps adding random videos to the queue when reaching the end of a queue. Disabling the extension makes the problem go away.
Root Cause
The
playlistLargePlaylistHandlerwas being initialized for all URLs with alistparameter, including queue-type playlists (Watch LaterWL, RadioRD, auto-generated mixes). The handler's index-sync logic interferes with YouTube's queue autoplay behavior, causing YouTube to add videos to the queue.Fix
WL,RD,RDAMVM...,OLAK5uy_...) inplaylistLargePlaylistHandlerinitPlayerChanges
js&css/web-accessible/www.youtube.com/playlist.js: Added queue-type check inplaylistLargePlaylistHandlerjs&css/web-accessible/functions.js: Added queue-type check in initPlayer playlist initialization