fix: include category chip bar in cursorLighting dimming rules (Fixes #4240) - #4255
Open
waterWang wants to merge 1 commit into
Open
fix: include category chip bar in cursorLighting dimming rules (Fixes #4240)#4255waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…ode-charity#4240) The cursorLighting feature (Dim YouTube's Pages except what I mouse-over) was missing CSS selectors for the category chip bar (ytd-feed-filter-chip-bar-renderer / #chips-wrapper). When cursorLighting is enabled, the chip bar is now properly dimmed to opacity .7 and restored to opacity 1 on hover, matching the behavior of other page elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4240
When the
cursorLightingfeature ("Dim YouTube's Pages, except what I mouse-over!") is enabled, the homepage category chip bar (ytd-feed-filter-chip-bar-renderer) was not included in the dimming CSS selectors.This caused the chip bar to appear blank/invisible while the rest of the page dimmed, and hovering over it did not restore visibility.
Changes
ytd-feed-filter-chip-bar-rendererand#chips-wrapperto thecursorLightingdimmed element selectors (opacity: 0.7)Testing