fix: apply thumbnail size setting to playlist video thumbnails in search results (Fixes #4248) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] - #4251
Open
waterWang wants to merge 1 commit into
Conversation
…rch results (Fixes code-charity#4248) When the user sets a custom thumbnail size (Large / Medium / Small / x-small / xx-small), the CSS only applied to ytd-video-renderer (regular search results) and ytd-compact-video-renderer (sidebar). Playlist video results in search use ytd-playlist-video-renderer, which was not targeted, so playlist thumbnails always remained at the default YouTube size. This commit adds the same size rules for ytd-playlist-video-renderer ytd-thumbnail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR fixes
When the user sets a custom thumbnail size (Large / Medium / Small / x-small / xx-small) in ImprovedTube settings, the CSS only applied to
ytd-video-renderer(regular search results) andytd-compact-video-renderer(sidebar). Playlist video results in search useytd-playlist-video-renderer, which was not targeted, so playlist thumbnails always remained at the default YouTube size.Change
Added 5 new CSS rules in
js&css/extension/www.youtube.com/styles.cssto apply the samemax-width/min-widthvalues toytd-playlist-video-renderer ytd-thumbnailfor each thumbnail size setting.How to test
Fixes #4248