Fix player controls options menu redirect - #4220
Open
floze-the-genius wants to merge 1 commit into
Open
Conversation
floze-the-genius
force-pushed
the
fix/4215-player-controls-menu
branch
from
August 9, 2026 19:57
f20bced to
e983e27
Compare
Author
|
@ImprovedTube2 I exact-rebased this onto current master (e983e27, 0 behind; patch-id unchanged). The focused redirect regression passes 1/1, the full Node 20 suite passes 24 suites / 110 tests, targeted ESLint passes, and both Chromium and Firefox archives build and pass integrity checks. Repository-wide and player.js lint baselines are unchanged from master. The new workflow is stopped at action_required before jobs start. Could you approve it and review when convenient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
section_1skeleton layerFixes #4215
Testing
master(55e3f681); the stable patch ID is unchanged and the branch is 0 behind / 1 aheadnpx jest tests/unit/player-controls-menu.test.js --runInBand(1 passed)npx --yes -p node@20 -c 'node --version && npm test -- --runInBand'(Node 20.20.2; 24 suites, 110 tests passed)ESLINT_USE_FLAT_CONFIG=true npx eslint --config tests/eslint_rules.config.mjs tests/unit/player-controls-menu.test.jspython3 build.py -chromium-stablefrombuild/; archive integrity verified withunzip -tpython3 build/build.py -firefox; archive integrity verified withunzip -tgit diff --check upstream/master...HEADThe repository-wide ESLint baseline is unchanged between
masterand this branch at 2,774 errors and 535 warnings. The existingmenu/skeleton-parts/player.jsbaseline is likewise unchanged at 17 errors and 60 warnings.AI disclosure
This pull request was implemented and validated with assistance from OpenAI Codex. The issue selection, repository policies, competing work, code path, regression coverage, and generated diff were independently checked before submission.