Skip to content

Fix player controls options menu redirect - #4220

Open
floze-the-genius wants to merge 1 commit into
code-charity:masterfrom
floze-the-genius:fix/4215-player-controls-menu
Open

Fix player controls options menu redirect#4220
floze-the-genius wants to merge 1 commit into
code-charity:masterfrom
floze-the-genius:fix/4215-player-controls-menu

Conversation

@floze-the-genius

@floze-the-genius floze-the-genius commented Jul 18, 2026

Copy link
Copy Markdown

Summary

  • correct the Player menu redirect to include the missing section_1 skeleton layer
  • add a regression test that resolves the real redirect and verifies it opens the shared hide-controls options section

Fixes #4215

Testing

  • rebased onto current master (55e3f681); the stable patch ID is unchanged and the branch is 0 behind / 1 ahead
  • npx jest tests/unit/player-controls-menu.test.js --runInBand (1 passed)
  • npx --yes -p node@20 -c 'node --version && npm test -- --runInBand' (Node 20.20.2; 24 suites, 110 tests passed)
  • ESLINT_USE_FLAT_CONFIG=true npx eslint --config tests/eslint_rules.config.mjs tests/unit/player-controls-menu.test.js
  • python3 build.py -chromium-stable from build/; archive integrity verified with unzip -t
  • python3 build/build.py -firefox; archive integrity verified with unzip -t
  • git diff --check upstream/master...HEAD

The repository-wide ESLint baseline is unchanged between master and this branch at 2,774 errors and 535 warnings. The existing menu/skeleton-parts/player.js baseline is likewise unchanged at 17 errors and 60 warnings.

AI disclosure

This pull request was implemented and validated with assistance from OpenAI Codex. The issue selection, repository policies, competing work, code path, regression coverage, and generated diff were independently checked before submission.

@floze-the-genius
floze-the-genius force-pushed the fix/4215-player-controls-menu branch from f20bced to e983e27 Compare August 9, 2026 19:57
@floze-the-genius

Copy link
Copy Markdown
Author

@ImprovedTube2 I exact-rebased this onto current master (e983e27, 0 behind; patch-id unchanged). The focused redirect regression passes 1/1, the full Node 20 suite passes 24 suites / 110 tests, targeted ESLint passes, and both Chromium and Firefox archives build and pass integrity checks. Repository-wide and player.js lint baselines are unchanged from master. The new workflow is stopped at action_required before jobs start. Could you approve it and review when convenient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot open "Player > Hide player controls buttons"

1 participant