Skip to content

Set __prop__ in editor mode #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shrinktofit wants to merge 1 commit into
base: v4.0.0
Choose a base branch
from
Open

Set __prop__ in editor mode #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cocos/core/data/class.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
if (CCClass.getInheritanceChain(cls)
// eslint-disable-next-line no-prototype-builtins
.some((x) => x.prototype.hasOwnProperty(propName))) {
errorID(3637, className, propName, className);

Check failure on line 81 in cocos/core/data/class.ts

View workflow job for this annotation

GitHub Actions / Run ESLint 

Unsafe argument of type `any` assigned to a parameter of type `StringSubstitution`

Check failure on line 81 in cocos/core/data/class.ts

View workflow job for this annotation

GitHub Actions / Run ESLint 

Unsafe argument of type `any` assigned to a parameter of type `StringSubstitution`

Check failure on line 81 in cocos/core/data/class.ts

View workflow job for this annotation

GitHub Actions / Run ESLint 

Unsafe argument of type `any` assigned to a parameter of type `StringSubstitution`
return;
}
}
Expand All @@ -86,10 +86,10 @@
appendProp(cls, propName);

// apply attributes
parseAttributes(cls, val, className, propName, false);

Check failure on line 89 in cocos/core/data/class.ts

View workflow job for this annotation

GitHub Actions / Run ESLint 

Unsafe argument of type `any` assigned to a parameter of type `string`

Check failure on line 89 in cocos/core/data/class.ts

View workflow job for this annotation

GitHub Actions / Run ESLint 

Unsafe argument of type `any` assigned to a parameter of type `string`

Check failure on line 89 in cocos/core/data/class.ts

View workflow job for this annotation

GitHub Actions / Run ESLint 

Unsafe argument of type `any` assigned to a parameter of type `PropertyStash`

Check failure on line 89 in cocos/core/data/class.ts

View workflow job for this annotation

GitHub Actions / Run ESLint 

Unsafe argument of type `any` assigned to a parameter of type `Function`
if ((EDITOR && !window.Build) || TEST) {
for (let i = 0; i < onAfterProps_ET.length; i++) {
onAfterProps_ET[i](cls, propName);

Check failure on line 92 in cocos/core/data/class.ts

View workflow job for this annotation

GitHub Actions / Run ESLint 

Unsafe argument of type `any` assigned to a parameter of type `string`

Check failure on line 92 in cocos/core/data/class.ts

View workflow job for this annotation

GitHub Actions / Run ESLint 

Unsafe argument of type `any` assigned to a parameter of type `Function`
}
onAfterProps_ET.length = 0;
}
Expand All @@ -100,14 +100,14 @@
const setter = val.set;

if (getter) {
parseAttributes(cls, val, name, propName, true);

Check failure on line 103 in cocos/core/data/class.ts

View workflow job for this annotation

GitHub Actions / Run ESLint 

Unsafe argument of type `any` assigned to a parameter of type `Function`
if ((EDITOR && !window.Build) || TEST) {
onAfterProps_ET.length = 0;
}

attributeUtils.setClassAttr(cls, propName, 'serializable', false);

if (DEV) {
if (EDITOR || DEV) {
// 不论是否 visible 都要添加到 props，否则 asset watcher 不能正常工作
appendProp(cls, propName);
}
Expand Down
Loading