Skip to content

feat(volo): add feature vendored for native-tls#301

Merged
yukiiiteru merged 2 commits into
cloudwego:mainfrom
ii64:fix/ci-native-tls-vendored
Jan 6, 2024
Merged

feat(volo): add feature vendored for native-tls#301
yukiiiteru merged 2 commits into
cloudwego:mainfrom
ii64:fix/ci-native-tls-vendored

Conversation

@ii64

@ii64 ii64 commented Dec 28, 2023

Copy link
Copy Markdown
Member

Motivation

Optional vendored feature flag, follow up for #296 (comment)
Users can choose wheter statically link native-tls library or using library that's provided by system package.

Solution

Add vendored feature that enables tokio-native-tls/vendored, use vendored flag in CI.

@ii64
ii64 requested review from a team December 28, 2023 06:23
@yukiiiteru

yukiiiteru commented Dec 28, 2023

Copy link
Copy Markdown
Contributor

Maybe the title could be clearer, and details can be put in commit messages, e.g.,

feat(volo): add feature `vendored` for `native-tls`

Add feature `vendored` that enables `tokio-native-tls/vendored`, and use it in CI to avoid installing additional packages.

Add feature `vendored` that enables `tokio-native-tls/vendored`, and use it in CI to avoid installing additional packages.
@ii64
ii64 force-pushed the fix/ci-native-tls-vendored branch from 9d0143c to 2876dfc Compare December 28, 2023 12:19
@ii64 ii64 changed the title feat(volo): vendored flag for volo native-tls, CI check feat(volo): add feature vendored for native-tls Dec 28, 2023
@yukiiiteru
yukiiiteru merged commit 62790d9 into cloudwego:main Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants