fix: show real created_at in trusted account attached general account… - #6148
Merged
seungyeoneeee merged 1 commit intoAug 3, 2026
Merged
Conversation
… table (CLO-1344) (cloudforet-io#6147) * fix: show real created_at in trusted account attached general account table (CLO-1344) The Created column in the connected General Account list rendered dayjs(value.data), but the PDataTable format slot passes the created_at string directly as value. Accessing .data on a string yielded undefined, so dayjs(undefined) produced the current time for every row. Use dayjs(value) to format the actual created_at value. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: 이승연 <sylee1274@mz.co.kr> * refactor: use iso8601Formatter for attached general account Created column (CLO-1344) Follow-up hardening from code review. This table can list PENDING accounts whose created_at may be absent; bare dayjs(value) would render 'Invalid Date' or, if undefined, silently reintroduce the current-time bug. iso8601Formatter null-guards (returns '') and uses the same 'YYYY-MM-DD HH:mm:ss' format, matching the sibling CollectorDetailAttachedServiceAccounts component. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: 이승연 <sylee1274@mz.co.kr> --------- Signed-off-by: 이승연 <sylee1274@mz.co.kr> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@seungyeoneeee is attempting to deploy a commit to the cloudforet Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
🎉 @skdud4659 has been randomly selected as the reviewer! Please review. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… table (CLO-1344) (#6147)
The Created column in the connected General Account list rendered dayjs(value.data), but the PDataTable format slot passes the created_at string directly as value. Accessing .data on a string yielded undefined, so dayjs(undefined) produced the current time for every row. Use dayjs(value) to format the actual created_at value.
Follow-up hardening from code review. This table can list PENDING accounts whose created_at may be absent; bare dayjs(value) would render 'Invalid Date' or, if undefined, silently reintroduce the current-time bug. iso8601Formatter null-guards (returns '') and uses the same 'YYYY-MM-DD HH:mm:ss' format, matching the sibling CollectorDetailAttachedServiceAccounts component.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
Things to Talk About (optional)