Skip to content

feat(nginx-strangler): router la connexion /api/v1/auth vers server-nestjs - #2826

Merged
StephaneTrebel merged 1 commit into
mainfrom
feat/auth-route-nginx
Oct 6, 2026
Merged

feat(nginx-strangler): router la connexion /api/v1/auth vers server-nestjs#2826
StephaneTrebel merged 1 commit into
mainfrom
feat/auth-route-nginx

Conversation

@shikanime

@shikanime shikanime commented Oct 6, 2026

Copy link
Copy Markdown
Member

Pourquoi

La bascule nginx doit être révisable (et réversible) indépendamment du code NestJS, conformément au découpage strangler.

Quoi

Références

Issue numéro: #2225

@shikanime
shikanime requested a review from a team as a code owner October 6, 2026 11:18
@github-actions github-actions Bot added the built label Oct 6, 2026
@shikanime
shikanime added this pull request to stack #2827 October 6, 2026 11:24
StephaneTrebel
StephaneTrebel reviewed Oct 6, 2026
View reviewed changes
Comment thread apps/nginx-strangler/conf.d/routing.conf
@StephaneTrebel StephaneTrebel mentioned this pull request Oct 6, 2026
Merged
StephaneTrebel
StephaneTrebel requested changes Oct 6, 2026
View reviewed changes

@StephaneTrebel StephaneTrebel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La configuration nginx est cohérente avec les autres proxys, mais elle route vers /api/v1/auth, endpoint absent de la branche parente à ce stade. La dépendance #2824 doit d’abord enregistrer et tester ce chemin contractuel ; rebasez ensuite cette branche sur son correctif.

@shikanime shikanime self-assigned this Oct 6, 2026
@shikanime shikanime added this to the 9.27.0 milestone Oct 6, 2026
@shikanime shikanime linked an issue Oct 6, 2026 that may be closed by this pull request
[NestJS] Porter la route GET /api/v1/auth depuis le serveur Fastify vers server-nestjs #2225
Closed
6 tasks
@shikanime
shikanime force-pushed the feat/auth-route-nginx branch from 1f70711 to 3124bb6 Compare October 6, 2026 13:35
StephaneTrebel
StephaneTrebel requested changes Oct 6, 2026
View reviewed changes

@StephaneTrebel StephaneTrebel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La règle Nginx exacte est correcte, mais le head de cette MR n’a pas changé et diverge toujours de sa branche parente actualisée (#2824 à 35f3db7). Je maintiens la demande de rebase et de contrôles CI sur le diff réconcilié.

@StephaneTrebel
StephaneTrebel self-requested a review October 6, 2026 15:13
StephaneTrebel
StephaneTrebel previously approved these changes Oct 6, 2026
View reviewed changes
@shikanime
shikanime force-pushed the feat/auth-route-nginx branch from 3124bb6 to 29edb55 Compare October 6, 2026 15:14
@shikanime shikanime added the preview Deploy preview app with Argo-cd label Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

A preview of the application is available at : https://console-pr-2826.dso.cpin-hp.numerique-interieur.fr

Please be patient, deployment may take a few minutes.

@shikanime
shikanime added this pull request to the merge queue Oct 6, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to invalid changes in the merge commit Oct 6, 2026
@shikanime
shikanime added this pull request to the merge queue Oct 6, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to invalid changes in the merge commit Oct 6, 2026
@StephaneTrebel
StephaneTrebel added this pull request to the merge queue Oct 6, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to invalid changes in the merge commit Oct 6, 2026
Base automatically changed from feat/auth-route-nestjs to main October 6, 2026 15:37
@shikanime @yorha-operator
feat(nginx-strangler): router la connexion /api/v1/auth vers server-n…
2bb0a92 
…estjs

Co-authored-by: Automata <automata@shikanime.studio>
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Change-Id: Icdcc4f1473c33cc2654b74af4da506406a6a6964
@cloud-pi-native-sonarqube

cloud-pi-native-sonarqube Bot commented Oct 6, 2026

Copy link
Copy Markdown

Passed Quality Gate passed

Issues

Measures

Project ID: cloud-pi-native_console_AYsa46O31ebDtzs-pYyZ

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephaneTrebel StephaneTrebel StephaneTrebel approved these changes

Assignees

@shikanime shikanime

Labels

built preview Deploy preview app with Argo-cd

Projects

None yet

Milestone

9.27.0

Development

Successfully merging this pull request may close these issues.

[NestJS] Porter la route GET /api/v1/auth depuis le serveur Fastify vers server-nestjs

2 participants

@shikanime @StephaneTrebel