Repository navigation
Conversation
shikanime
marked this pull request as draft
October 2, 2026 14:19
shikanime
added a commit
to shikanime-labs/skills
that referenced
this pull request
Oct 2, 2026
Design: skills/sks-code-authoring/ Related: cloud-pi-native/console#2811 carries cpn-code-authoring Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio> Change-Id: I6add530d32944e5563bf7f7a7b551ad86a6a6964
shikanime
changed the title
StephaneTrebel
previously requested changes
Oct 5, 2026
StephaneTrebel
left a comment
StephaneTrebel
left a comment
Collaborator
There was a problem hiding this comment.
La migration allège correctement le contexte global, mais elle supprime aussi une règle d’architecture sans la préserver dans le skill. Le changement doit conserver cette convention avant intégration.
shikanime
force-pushed
the
chore/trim-agents-md
branch
2 times, most recently
from
October 5, 2026 13:18
4718486 to
195296e
Compare
shikanime
force-pushed
the
chore/trim-agents-md
branch
from
October 5, 2026 13:35
195296e to
5e34585
Compare
shikanime
commented
Oct 7, 2026
shikanime
left a comment
shikanime
left a comment
Member
Author
There was a problem hiding this comment.
La migration des conventions d'authoring vers .agents/skills/cpn-code-authoring est bien découpée : le skill reprend fidèlement les règles de tests déterministes (fenêtre de tirage faker) et de mockDeep retirées d'AGENTS.md, et la section Boundaries clarifie ce qui reste dans AGENTS.md. Une seule règle disparaît sans reprise visible : « Helpers return new objects; do not mutate inputs » — à confirmer dans le skill privé (shikanime-labs/skills#360) ou à réintégrer. Titre sans scope (docs: au lieu de docs(scope):) et premier commit qui mentionne sks-code-authoring au lieu de cpn-code-authoring, à harmoniser. Le flag draft est approprié tant que les règles continuent d'être ratifiées depuis les revues.
shikanime
marked this pull request as ready for review
October 8, 2026 11:32
shikanime
force-pushed
the
chore/trim-agents-md
branch
2 times, most recently
from
October 8, 2026 12:25
aa4c00e to
3ad5bf8
Compare
Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: Shikanime Deva <22115108+shikanime@users.noreply.github.com>
Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: Shikanime Deva <22115108+shikanime@users.noreply.github.com>
Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: Shikanime Deva <22115108+shikanime@users.noreply.github.com>
Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: Ib5f2c9f757ac12a821e96a74e9a849b06a6a6964 Signed-off-by: Shikanime Deva <22115108+shikanime@users.noreply.github.com>
Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: Shikanime Deva <22115108+shikanime@users.noreply.github.com>
Ratifies the get/create/ensure/reconcile vocabulary and module-local ensure() util routing from #2832. Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: Shikanime Deva <22115108+shikanime@users.noreply.github.com>
ensure* primitives in xxx-client.service.ts; service-layer ensure* is private composition that never re-implements race recovery; reconcile* (collection sweep, may delete) only in xxx.service.ts. Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: Shikanime Deva <22115108+shikanime@users.noreply.github.com>
Deduplicate the strangler-fig rules out of SKILL.md into references/migration-parity.md, referenced from the section and the description. Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: Shikanime Deva <22115108+shikanime@users.noreply.github.com>
cpn-create-skill profile mandates metadata.version over a root-level version field; sibling skills follow it. Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: Shikanime Deva <22115108+shikanime@users.noreply.github.com>
shikanime
force-pushed
the
chore/trim-agents-md
branch
from
October 8, 2026 13:02
c1274d9 to
2aa0042
Compare
Mirror the cross-reference convention used by cpn-delegate, cpn-merge, and cpn-release-patch. Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: Shikanime Deva <22115108+shikanime@users.noreply.github.com>
Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: Shikanime Deva <22115108+shikanime@users.noreply.github.com>
Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
StephaneTrebel
approved these changes
Oct 9, 2026
StephaneTrebel
left a comment
StephaneTrebel
left a comment
Collaborator
There was a problem hiding this comment.
✨ Le déplacement des conventions de test vers le skill les rend découvrables sans alourdir AGENTS.md, et les règles de parité sont externalisées dans une référence ciblée. Aucun écart relevé dans le diff ; la CI est verte.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quoi
Déplace les conventions d'authoring d'
AGENTS.mdvers un skill.agents/skills/cpn-code-authoringconsultable par les agents, puis lecomplète avec le vocabulaire des services clients ratifié dans #2832 :
get*/create*/ensure*(+reconcile*pour les sweeps planifiés),routage par le
ensure()util module-local, miroir verbatim des verbesdes API externes, et l'exception de réutilisation des secrets.
Pourquoi
AGENTS.md porte des règles de fixture/test que seuls les agents appliquent ;
un skill dédié les charge à la demande. Le vocabulaire manquait au skill
alors qu'il vient d'être ratifié.
Références