Repository navigation
fix(vault): avoid double slash in KV list path for Vault 2.0 - #2678
Merged
Merged
Conversation
StephaneTrebel
previously approved these changes
Sep 14, 2026
shikanime
enabled auto-merge
September 30, 2026 13:17
iliesmrf
disabled auto-merge
October 1, 2026 07:26
iliesmrf
force-pushed
the
fix/vault-2.0-path
branch
from
October 1, 2026 07:35
1dd07d3 to
9a85607
Compare
iliesmrf
enabled auto-merge
October 1, 2026 07:35
shikanime
approved these changes
Oct 1, 2026
shikanime
disabled auto-merge
October 1, 2026 07:59
shikanime
enabled auto-merge
October 1, 2026 07:59
iliesmrf
force-pushed
the
fix/vault-2.0-path
branch
from
October 1, 2026 08:15
9a85607 to
5cfabb5
Compare
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (62.10% Estimated after merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro:
Quel est le comportement actuel ?
VaultProjectApi.list()ajoute systématiquement un/final à l'URL de requête vers Vault, même quand lepathfourni en contient déjà un (cas de l'argument par défaut/, et des appels récursifs sur les sous-dossiers renvoyés par la réponse LIST de Vault). L'URL générée contient alors un//.Vault 1.21 tolère ça silencieusement, mais Vault 2.0 impose la canonicalisation des paths et rejette toute requête contenant
//,/./ou/../.Cette méthode est utilisée par
archiveDsoProject(functions.ts) pour lister puis détruire tous les secrets sous le chemin KV d'un projet lors de son archivage. Sans correctif, ce nettoyage échouerait silencieusement dès le passage de la plateforme à Vault 2.0.Quel est le nouveau comportement ?
Le path est normalisé avant construction de l'URL pour ne jamais produire qu'un seul slash final, que le
pathen ait déjà un ou non. Le comportement fonctionnel delist()est inchangé (mêmes résultats retournés), seule l'URL générée est corrigée.Cette PR introduit-elle un breaking change ?
Non.
Autres informations
Correctif préventif préparé en amont de la mise à niveau de la plateforme verhelm
0.34.1 /imageVersion: "2.0.4", cf. PR associée sur le reposocle`).