Skip to content

test(server-nestjs): parité reconcile-only des rôles admin keycloak + garde d'émission - #2581

Closed
shikanime wants to merge 3 commits into
mainfrom
test/keycloak-admin-role-parity
Closed

test(server-nestjs): parité reconcile-only des rôles admin keycloak + garde d'émission#2581
shikanime wants to merge 3 commits into
mainfrom
test/keycloak-admin-role-parity

Conversation

@shikanime

@shikanime shikanime commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Issues liées

Refs #2574
Refs #2576

Quel est le comportement actuel ?

Legacy déclenche hook.adminRole.upsert/delete à chaque create/patch/delete de rôle admin ; server-nestjs ne synchronise les groupes OIDC que via le cron reconcile, sans chemin évènementiel ni module admin-role.

Quel est le nouveau comportement ?

  • keycloak.service.spec.ts : +35 lignes — describe('migration parity: admin-role event path') : (a) verrouille la sync des groupes OIDC via cron uniquement, (b) garde négative « pas d'emitAdminRoleEvent » sur AppEventsService pour forcer tout futur chemin évènementiel à passer par l'audit de parité.

12/12 tests verts sur Node 24.

Cette PR introduit-elle un breaking change ?

Non.

Autres informations

Blocant cutover latent tracé côté migration (matrice u5/u9).

@shikanime shikanime mentioned this pull request Aug 25, 2026
Open
10 tasks
@github-actions github-actions Bot added the built label Aug 25, 2026
@shikanime shikanime closed this Aug 28, 2026
@shikanime
shikanime deleted the test/keycloak-admin-role-parity branch August 28, 2026 15:49
@shikanime shikanime reopened this Aug 28, 2026
@shikanime
shikanime force-pushed the test/keycloak-admin-role-parity branch from f89913c to b768efb Compare August 31, 2026 10:09
shikanime
shikanime commented Sep 9, 2026
View reviewed changes

@shikanime shikanime left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict : Changements demandés

Les gardes de parité (« cet évènement n'existe pas volontairement ») sont une bonne idée et les specs sont bien rédigées. En revanche la PR mélange trois sujets : la parité keycloak (le titre), l'audit migration-parité et la parité vault/zone + e2e, plus deux documents de notes internes. À scinder — le cœur keycloak est prêt.

Comment thread apps/server-nestjs/documentation/MIGRATION-PARITY-MATRIX.md Outdated
Comment thread apps/server-nestjs/src/modules/keycloak/keycloak.service.spec.ts Outdated
Comment thread apps/server-nestjs/src/modules/keycloak/keycloak.service.spec.ts
@shikanime
shikanime force-pushed the test/keycloak-admin-role-parity branch 2 times, most recently from 597423f to 3c6b765 Compare September 9, 2026 14:20
@shikanime shikanime mentioned this pull request Sep 11, 2026
Open
4 tasks
@shikanime shikanime self-assigned this Sep 17, 2026
@shikanime shikanime added this to the 9.27.0 milestone Sep 17, 2026
shikanime
shikanime commented Sep 17, 2026
View reviewed changes
Comment thread apps/server-nestjs/src/modules/keycloak/keycloak.service.spec.ts
shikanime
shikanime commented Sep 17, 2026
View reviewed changes
Comment thread apps/server-nestjs/src/modules/keycloak/keycloak.service.spec.ts
shikanime
shikanime commented Sep 17, 2026
View reviewed changes
Comment thread apps/server-nestjs/src/modules/keycloak/keycloak.service.spec.ts Outdated
shikanime
shikanime commented Sep 17, 2026
View reviewed changes
Comment thread apps/server-nestjs/src/modules/keycloak/keycloak.service.spec.ts Outdated
shikanime
shikanime commented Sep 17, 2026
View reviewed changes
Comment thread apps/server-nestjs/src/modules/keycloak/keycloak.service.spec.ts Outdated
shikanime
shikanime commented Sep 17, 2026
View reviewed changes
Comment thread apps/server-nestjs/src/modules/events/app-events.service.spec.ts Outdated
@shikanime
shikanime force-pushed the test/keycloak-admin-role-parity branch from 3c6b765 to 65cdf74 Compare September 17, 2026 15:29
@shikanime shikanime added the preview Deploy preview app with Argo-cd label Sep 24, 2026
@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

A preview of the application is available at : https://console-pr-2581.dso.cpin-hp.numerique-interieur.fr

Please be patient, deployment may take a few minutes.

@shikanime
shikanime force-pushed the test/keycloak-admin-role-parity branch 2 times, most recently from e60c6ac to 6197a04 Compare September 25, 2026 15:31
@shikanime shikanime removed the preview Deploy preview app with Argo-cd label Sep 28, 2026
@shikanime shikanime moved this to Backlog in Cloud Pi Native Sep 29, 2026
@shikanime
shikanime requested review from a team and StephaneTrebel and removed request for StephaneTrebel September 29, 2026 13:07
shikanime
shikanime commented Sep 30, 2026
View reviewed changes

@shikanime shikanime left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict : Commentaire

Le garde d'émission est utile et non tautologique (il échoue si quelqu'un ajoute un émetteur sans retirer le routeur legacy). Un conflit inter-PR est toutefois programmé : #2487 ajoute précisément emitZoneEvent au même service.

Comment thread apps/server-nestjs/src/modules/events/app-events.service.spec.ts Outdated
@shikanime shikanime added the enhancement New feature or request label Oct 1, 2026
@shikanime
shikanime force-pushed the test/keycloak-admin-role-parity branch 2 times, most recently from 204df59 to 6a75598 Compare October 1, 2026 16:38
StephaneTrebel
StephaneTrebel reviewed Oct 2, 2026
View reviewed changes
Comment thread apps/server-nestjs/src/modules/keycloak/keycloak.service.spec.ts Outdated
StephaneTrebel
StephaneTrebel requested changes Oct 2, 2026
View reviewed changes

@StephaneTrebel StephaneTrebel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La vérification cron reste utile, mais le garde négatif sur emitAdminRoleEvent contredit maintenant le pont événementiel requis par #2749. Retirer ou remplacer ce garde, puis rebaser les 46 commits manquants et relancer les contrôles avant nouvelle revue.

@iliesmrf iliesmrf modified the milestones: 9.27.0, 9.28.0 Oct 2, 2026
@shikanime
shikanime force-pushed the test/keycloak-admin-role-parity branch from 9b07432 to cea6a0b Compare October 2, 2026 11:57
@StephaneTrebel

StephaneTrebel commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Relecture de la tête actuelle : les tests de réconciliation Keycloak restent cohérents, mais cette PR de test est en brouillon ; aucun verdict formel n’est publié.

@shikanime
shikanime force-pushed the test/keycloak-admin-role-parity branch from fca39f0 to 2ed34fb Compare October 2, 2026 15:01
shikanime and others added 3 commits October 2, 2026 17:09
@shikanime @yorha-operator
test(server-nestjs): assert app events emit surface parity
f2459a0 
Co-authored-by: Automata <automata@shikanime.studio>
@shikanime @yorha-operator
test(server-nestjs): drop cutover guard forbidding emitAdminRoleEvent
af9265f 
Co-authored-by: Automata <automata@shikanime.studio>
@shikanime @yorha-operator
test(events): drop the emitZoneEvent absence guard superseded by the …
c593107 
…zone migration

Co-authored-by: Automata <automata@shikanime.studio>
@shikanime
shikanime force-pushed the test/keycloak-admin-role-parity branch from 2ed34fb to c593107 Compare October 2, 2026 15:09
@cloud-pi-native-sonarqube

cloud-pi-native-sonarqube Bot commented Oct 2, 2026

Copy link
Copy Markdown

Passed Quality Gate passed

Issues

Measures

Project ID: cloud-pi-native_console_AYsa46O31ebDtzs-pYyZ

View in SonarQube

@iliesmrf iliesmrf closed this Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephaneTrebel StephaneTrebel Awaiting requested review from StephaneTrebel

Assignees

@shikanime shikanime

Labels

built enhancement New feature or request

Projects

None yet

Milestone

9.28.0

Development

Successfully merging this pull request may close these issues.

3 participants

@shikanime @StephaneTrebel @iliesmrf