Added support for search - #88
Open
calvinfroedge wants to merge 1 commit into
Open
calvinfroedge wants to merge 1 commit into
calvinfroedge wants to merge 1 commit into
Conversation
|
+1 Any chance of this getting merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for your work on this library. I needed to implement the search feature for my API, and noticed that it wasn't supported, so I added it.
I only had to refactor clutch.clj a tiny bit.
I had to change the response handler quite a bit, as (rest lines) was not defined for some reason when returning from the search URL.
I don't think I broke anything else, but I was unable to run the tests, even with a fresh repo (unchanged), so I definitely suggest you run the tests yourself. I kept getting lots of these:
ERROR in (use-type-as-db-arg) (PlainSocketImpl.java:-2) Uncaught exception, not in assertion. expected: nil actual: java.net.ConnectException: Connection refused at java.net.PlainSocketImpl.socketConnect (PlainSocketImpl.java:-2)