Prevent image-transform worker deadlocks - #252
Merged
Merged
Conversation
clemsgrs
force-pushed
the
agent/issue-245
branch
from
July 28, 2026 11:33
4424076 to
beaa8e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawnDataLoader contextRoot cause
The image embedding paths loaded the encoder/runtime before constructing a DataLoader. Default worker selection then forked transform workers from a parent with initialized native threads, which could leave sleeping workers and deadlock the run.
User impact
Default dense-image and pooled-image embedding now complete without post-runtime worker forks. Explicit zero remains supported, while callers that explicitly request worker parallelism keep it through spawned workers.
Validation
Model.embed_images_dense(...)andModel.embed_images(...)subprocess regressions passed and reported no active child workersgit diff --checkpassedmain...HEADreview passed after both Standards judgement calls were resolved; Spec reported no findingsCloses #245