fix: support root :scope selectors#5266
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
puneetdixit200
force-pushed
the
fix/root-scope-selector
branch
from
13d67a6 to
b850196
Compare
Member
|
Hi @puneetdixit200, this change really should be split across the dependencies, not implemented exclusively in Cheerio. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4509.
This updates root-scoped selector handling so
:scope > ...works when the current Cheerio selection is the document root. The document root cannot be matched directly by the underlying element-only selector path, so the root:scopecase is rewritten to select from top-level root elements while keeping the existing element-scoped path unchanged.I added a regression test that includes a nested matching element to make sure
:scope > ...only matches direct children of the document root.Validated with:
npm run test:vi -- src/api/traversing.spec.ts -t ":scope on the document root"npm run test:vi -- src/api/traversing.spec.tsnpm run test:vinpm run lint:tsnpm run lint:biomenpx eslint src/api/traversing.ts src/api/traversing.spec.tsnpm run buildNote: I also tried
npm run test; it currently stops during repo-wide ESLint while lintingwebsite/src/content.config.tsbecauseastro/tsconfigs/strictis not available from the root install.