Repository navigation
feat: update checkstyle to 14.3.0 - #624
Merged
Merged
Conversation
Release-As: 14.3.0
|
There was a problem hiding this comment.
🟡 Changes recommended
The new private constructors and final modifiers introduce compatibility breaks, while the PMD workaround disables a rule globally.
2 open findings
What changed in this PR
Updates the plugin to Checkstyle 14.3.0 and adjusts verification tooling and formatting.
Changes:
- Upgrades Checkstyle, PMD, and SpotBugs dependencies.
- Updates rule-count expectations and compatibility documentation.
- Adds suppressions and formatting changes for verification.
| File | Description |
|---|---|
pom.xml |
Upgrades dependencies and pins verification configuration. |
README.md |
Adds Checkstyle 14.3.0 compatibility. |
config/suppressions.xml |
Suppresses MissingCtor in tests. |
config/pmd-main.xml |
Disables a PMD rule globally. |
src/main/java/org/sonar/plugins/checkstyle/metadata/SonarRulePropertyLoader.java |
Adds private constructors and final modifiers. |
src/main/java/org/sonar/plugins/checkstyle/metadata/ModuleFactory.java |
Applies formatting. |
src/main/java/org/sonar/plugins/checkstyle/metadata/CheckUtil.java |
Applies formatting. |
src/main/java/org/sonar/plugins/checkstyle/metadata/CheckstyleMetadata.java |
Applies formatting. |
src/main/java/org/sonar/plugins/checkstyle/CheckstyleSeverityUtils.java |
Applies formatting. |
src/main/java/org/sonar/plugins/checkstyle/CheckstyleSensor.java |
Applies formatting. |
src/main/java/org/sonar/plugins/checkstyle/CheckstyleRulesDefinition.java |
Applies formatting. |
src/main/java/org/sonar/plugins/checkstyle/CheckstyleProfileExporter.java |
Reformats wrapped parameters. |
src/main/java/org/sonar/plugins/checkstyle/CheckstylePlugin.java |
Applies formatting. |
src/main/java/org/sonar/plugins/checkstyle/CheckstyleExecutor.java |
Applies formatting. |
src/main/java/org/sonar/plugins/checkstyle/CheckstyleConstants.java |
Applies formatting. |
src/main/java/org/sonar/plugins/checkstyle/CheckstyleConfiguration.java |
Applies formatting. |
src/test/java/org/sonar/plugins/checkstyle/CheckstyleSensorTest.java |
Applies formatting. |
src/test/java/org/sonar/plugins/checkstyle/CheckstyleRulesDefinitionTest.java |
Updates the expected rule count. |
src/test/java/org/sonar/plugins/checkstyle/CheckstyleProfileExporterTest.java |
Applies formatting. |
src/test/java/org/sonar/plugins/checkstyle/CheckstyleAuditListenerTest.java |
Applies formatting. |
src/it/java/org/checkstyle/plugins/sonar/RunPluginTest.java |
Applies formatting. |
src/it/java/org/checkstyle/plugins/sonar/CheckJarTest.java |
Applies formatting. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+26
to
+30
| public final class SonarRulePropertyLoader { | ||
|
|
||
| private List<AdditionalRuleProperties> rules; | ||
|
|
||
| private SonarRulePropertyLoader() { |
Comment on lines
+20
to
+21
| <!-- Jackson instantiates SonarRulePropertyLoader through its private constructor --> | ||
| <exclude name="MissingStaticMethodInNonInstantiatableClass"/> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #621
also updates dependencies like PMD and sets new suppressions for test classes after the Checkstyle upgrade to make verfication pass