Skip to content

Unused method, demands RequireJS, general praise #1

Description

@katowulf

Hi there,

Great little module! Thanks for posting. I've tried a few different mixin models for Backbone and this is by far the simplest, most direct, and most useful : )

I love the fact that it works with _super!

A couple thoughts for you:

  • The method implementMixins appears to be unused? Unless this is magically called somehow from RequireJS.
  • Use of this module demains RequireJS. Could it be wrapped so that if RequireJS doesn't exist it just applies itself to backbone? I stripped the wrappings to utilize this lib. At the very least, mention this dependency in the README? Not being a RequireJS aficionado, it took me a bit to solve this mystery.

Cheers, and thanks for a great tool!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions