CFE-3366: gate storage promise fstab edits and mount point creation on the promise action - #6344
Open
nickanderson wants to merge 2 commits into
Open
CFE-3366: gate storage promise fstab edits and mount point creation on the promise action#6344nickanderson wants to merge 2 commits into
nickanderson wants to merge 2 commits into
Conversation
Each edit is now gated on MakingInternalChanges(), matching mount, unmount and the remount reconciliation. Ticket: CFE-3366 Changelog: Title
…n-only A mount promise created its mount point with MakeParentDirectory() before consulting the promise action, so action_policy => "warn" and --dry-run both left a directory behind on a run that was supposed to change nothing. The directory is now created only when MakingInternalChanges() allows it. Ticket: CFE-3366 Changelog: Title
Member
Author
|
@cf-bottom jenkins, please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14627/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14627/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A storage promise with
edit_fstabrewrote/etc/fstaband created its mountpoint even under
action_policy => "warn"or--dry-run, reporting a repair itdid not make. Both are now gated on
MakingInternalChanges(), matching whatmount, unmount and remount already do.