ENT-14434: Move reactor-pluigin logic into cf-reactor daemon loop - #6335
Open
victormlg wants to merge 1 commit into
Open
ENT-14434: Move reactor-pluigin logic into cf-reactor daemon loop#6335victormlg wants to merge 1 commit into
victormlg wants to merge 1 commit into
Conversation
victormlg
marked this pull request as ready for review
August 25, 2026 14:45
victormlg
force-pushed
the
cf-reactor-move-around
branch
from
August 25, 2026 14:46
2e7ed0e to
dfd91c6
Compare
larsewi
reviewed
Aug 26, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
Please add some more context. E.g., explain why chose to make cf-reactor plugin its own process. Also I expected cf-reactor in nova to already fork out and make it a daemon, but I have not seen this code removed.
larsewi
requested changes
Aug 28, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
There one major issue here. If the nova fork dies, then core will continue running and no one will restart the nova reactor again. With this architecture, core must be responsible for restarting the nova fork if it dies.
victormlg
force-pushed
the
cf-reactor-move-around
branch
3 times, most recently
from
August 28, 2026 12:44
553a07c to
aa6d538
Compare
victormlg
force-pushed
the
cf-reactor-move-around
branch
2 times, most recently
from
August 28, 2026 12:50
7228cb8 to
be91f14
Compare
larsewi
reviewed
Aug 28, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
Please write a test where you kill the nova cf-reactor and see that it comes back. Maybe also test reaching that limit that you set.
victormlg
force-pushed
the
cf-reactor-move-around
branch
from
September 1, 2026 09:57
be91f14 to
a7fd033
Compare
victormlg
changed the title
Contributor
Author
|
I updated the context of this PR to match what it currently contains |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
victormlg
force-pushed
the
cf-reactor-move-around
branch
from
September 1, 2026 10:07
a7fd033 to
5d32781
Compare
victormlg
force-pushed
the
cf-reactor-move-around
branch
from
September 1, 2026 12:34
5d32781 to
9effa41
Compare
larsewi
reviewed
Sep 1, 2026
victormlg
force-pushed
the
cf-reactor-move-around
branch
from
September 2, 2026 12:07
9effa41 to
03575f1
Compare
The code for the reactor-plugin was split up into different functions to be integrated inside the new cf-reactor daemon in core. The implementation was tweaked to use select(2) instead of poll(2), to support cf-reactor on different platforms. However, the reactor-plugin remains linux only. Ticket: ENT-14434 Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
cf-reactor-move-around
branch
from
September 2, 2026 12:09
03575f1 to
1b638a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
So originally, we wanted to have two daemons: one for cf-reactor and one for the agent driven cfengine code. Then it has been decided to merge these two binaries into a single one. In this PR, we move the cf-reactor daemon to core, split the reactor-plugin in different functions, and integrate them inside the daemon loop of cf-reactor
Merge together: https://github.com/cfengine/enterprise/pull/996 https://github.com/cfengine/nova/pull/2696