docs: add infomaniak third party provider#2092
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
There was a problem hiding this comment.
Pull request overview
Adds a third-party alternative Infomaniak DNS01 webhook link to the cert-manager DNS01 provider documentation (addressing issue #1935) so users can discover an externally maintained option alongside the existing official provider.
Changes:
- Add a new “third-party alternative” documentation link for an Infomaniak webhook implementation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - [`cert-manager-webhook-hetzner`](https://github.com/vadimkim/cert-manager-webhook-hetzner) | ||
| - [`cert-manager-webhook-ibmcis`](https://github.com/jb-dk/cert-manager-webhook-ibmcis) | ||
| - [`cert-manager-webhook-infomaniak`](https://github.com/Infomaniak/cert-manager-webhook-infomaniak) | ||
| - [`cert-manager-webhook-infomaniak`](https://github.com/M0NsTeRRR/cert-manager-webhook-infomaniak) (third-party alternative) |
wallrj-cyberark
left a comment
There was a problem hiding this comment.
Thank you for the contribution. Rather than listing a second webhook with the same name, I would suggest contributing your improvements to the original Infomaniak webhook instead.
The improvements you describe (distroless image, rootless security context, updated dependencies, OCI artifacts) would benefit all existing users of that webhook. The original repository accepts external contributions — it has 14 merged PRs from community contributors. In fact, some of your stated improvements align with work already requested there:
- #5: "feat: add default security context" — directly related to your rootless/distroless changes
- There are also 5 open dependabot PRs for dependency updates that could use a reviewer
Listing two entries with the identical display name cert-manager-webhook-infomaniak would be confusing for readers, and the "(third-party alternative)" annotation does not resolve this — every entry in this list is third-party.
I would encourage you to open PRs upstream and, if the maintainers are unresponsive after a reasonable period, revisit the question of a separate listing at that point.
|
Hello, Thank you for your input. However, I don’t agree with some parts of your conclusion. I thought about this before creating an alternative project and upstreaming the issue I addressed. The problem is the lack of dependency updates, which is on the maintainer’s side. Even if I reviewed it, the maintainer would still need to review it as well, especially regarding trustworthiness. I’ve already contacted Infomaniak support, provided them with what I did, and they said they would forward it to their appropriate team and I got no answer for now. Also, like many users (and I assume you as well), before creating a PR for any project I contribute to, I first reach out to the maintainers to see if they’re interested in this kind of evolution. This way, I avoid wasting my time if they don’t agree. Since the issues are closed, I can’t do that.
Exactly, that’s why I also opened the issue first and created the PR in the meantime, it didn’t take much time. |
Hello,
Differences between mine and the official one :
Fix issue #1935