Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 705e611165
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| else | ||
| echo " [$i]: $arg" >&2 |
There was a problem hiding this comment.
When the enclave is launched with credentials in --signer.header, an RPC URL, or --espresso.testing-batcher-private-key, this fallback prints the complete argument to container logs because only --private-key and --mnemonic are recognized as secrets. This can expose remote-signer authorization tokens, provider API keys, or another private key; redact these credential-bearing flags and sensitive URL components rather than logging them verbatim.
Useful? React with 👍 / 👎.
| # Batcher flags whose values are URLs | ||
| URL_ARG_RE='^(--altda\.da-server|--espresso\.espresso-attestation-service|--espresso\.urls|--espresso\.l1-url|--l1-eth-rpc|--l2-eth-rpc|--rollup-rpc|--signer\.endpoint)(=|$)' |
There was a problem hiding this comment.
When --throttle.additional-endpoints contains localhost, 127.0.0.1, or host endpoints exposed by the enclave parent, this regex leaves them in filtered_args instead of routing them through the Odyn/socat bridge. The batcher includes these URLs in its throttling endpoint set, so requests then target the enclave itself and throttling updates to those builders fail; include this StringSlice URL flag in the rewrite path.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@shenkeyao please fix this as well.
This regexp should work:
URL_ARG_RE='^(--altda\.da-server|--espresso\.espresso-attestation-service|--espresso\.urls|--espresso\.l1-url|--l1-eth-rpc|--l2-eth-rpc|--rollup-rpc|--signer\.endpoint|--throttle\.additional-endpoints)(=|$)'
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21d9a60cdb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e858b64f5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Hey @ezdac a bit of context on this one: This is the code needed to generate the TEE batcher enclave image. We already used this code from our fork of this repository in order to spinup the TEE batcher currently running in the testnet. See EspressoSystems#1. |
2 participants
Based on #459.
op-batcher-enclave-appandop-batcher-enclave-targetas targets inops/docker/op-stack-go/Dockerfile.op-batcher/enclave-toolsand ajust enclave-toolsrecipe.ghcr.io/celo-org/optimismon pushes and PRs toespresso/**.--espresso.batch-authenticator-addrand--espresso.rollup-l1-urlfrom the ported scripts.