Conversation
| return fmt.Errorf("tx manager does not implement ChainSigner") | ||
| tcfg := cfg.TxMgrConfig | ||
|
|
||
| // Mirror the txmgr's backwards-compatible HD-path resolution. |
Collaborator
There was a problem hiding this comment.
As we are using the KMS to sign payloads sent to the BatchAuthenticator contract do we need this?
Collaborator
Author
There was a problem hiding this comment.
We use it only for the mnemonic/private-key fallback paths. When the KMS signer is enabled the hdPath is ignored. But the factory still needs it for the other two branches, and it must resolve the path identically to txmgr or a mnemonic would derive a different key.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #505.
The batcher now builds its Espresso
ChainSigneritself, so txmgr no longer carries any Espresso-specific signing API. This keepsop-service/txmgr's public surface identical to upstream, which matters for our rebases.